test: migrate to snapshots

[snitin315]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

yes added snapshots

Motivation / Use-Case

use snapshots for tests.

Breaking Changes

No

Additional Info

No

[snitin315]

fixing CI

[codecov]

Codecov Report

Merging #3158 (1bb4f77) into master (2c92d3c) will not change coverage.
The diff coverage is n/a.

❗ Current head 1bb4f77 differs from pull request most recent head 02d6fe0. Consider uploading reports for the commit 02d6fe0 to get more accurate results

@@           Coverage Diff           @@
##           master    #3158   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files          37       37           
  Lines        1218     1218           
  Branches      338      338           
=======================================
  Hits         1157     1157           
  Misses         55       55           
  Partials        6        6           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c92d3c...02d6fe0. Read the comment docs.

[snitin315]

We have a warning on node 12 for windows -

(node:4752) [DEP0131] DeprecationWarning: The legacy HTTP parser is deprecated.

Should we strip it in the snapshot?

[alexander-akait]

Should we strip it in the snapshot?

Yep, let's remove it

[alexander-akait]

Let's merge this after webpack/webpack-cli#2573, otherwise we need rebase again, it is painful for snapshots

[snitin315]

Let's merge this after webpack/webpack-cli#2573, otherwise we need rebase again, it is painful for snapshots

Both PRs are in different repositories, am I missing something here?

[alexander-akait]

Oh, yes, my mistake