fix: respect open and bonjour for node API
#1540
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
force-pushed
the
issue-1510
branch
from
c055245 to
a8d89e8
Compare
alexander-akait
force-pushed
the
issue-1510
branch
from
a8d89e8 to
7689ea0
Compare
|
Problem in tests, need rewrite tests first 😞 Let's start refactoring |
6 tasks
2 tasks
|
Need rewrite logic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
fixes #1510 also
bonjouris broken too usingnodeAPIMotivation / Use-Case
fix bug
Breaking Changes
No
Additional Info
It is hard tests for
external, i think we mockopenfunction and just check on call. We need rewrite tests, around 1/3 tests are broken locally due8000/8080port can be busy other processes.Some refactoring included.
We can move around 50% code
Serverto utils. I can start with tests and when refactor code.