[WIP]: add "open" option to node api to allow opening in browser #1627
Conversation
amilajack
requested review from
alexander-akait and
michael-ciniawsky
as code owners
|
Does this conflict with #1540? |
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
- Coverage 74.27% 74.02% -0.25%
==========================================
Files 10 10
Lines 688 693 +5
==========================================
+ Hits 511 513 +2
- Misses 177 180 +3
Continue to review full report at Codecov.
|
| `${openMessage}. If you are running in a headless environment, please do not use the --open flag` | ||
| ); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Don't move this from utils
| if (this.options.open) { | ||
| const suffix = (this.options.inline !== false || this.options.lazy === true ? '/' : '/webpack-dev-server/'); | ||
| const uri = createDomain({ host: hostname, port }, this.listeningApp) + suffix; | ||
| openBrowser(uri, this.options, this.log); |
There was a problem hiding this comment.
It is should be in listen event and remove logic for open from bin file
There was a problem hiding this comment.
remove logic for open from bin file
I'm not sure what do you mean by this. The previous comment says that open logic should be kept in bin
There was a problem hiding this comment.
Also socksjs doesn't seem to register a 'listen' event. On what object should i listen for and where should i call it?
There was a problem hiding this comment.
There was a problem hiding this comment.
But if I listen with express what port should i listen on? Also i don't understand the reason for listening on another port with express. Can you please explain this.
|
@evilebottnawi @michael-ciniawsky it seems like #1540 does the same thing as this PR. Should this PR be closed in favor of that PR? |
|
@amilajack PR was abadoned, so you can continue develop |
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
- Coverage 74.27% 74.02% -0.25%
==========================================
Files 10 10
Lines 688 693 +5
==========================================
+ Hits 511 513 +2
- Misses 177 180 +3
Continue to review full report at Codecov.
|
|
friendly ping @amilajack |
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Node api does not support open option
Breaking Changes
Additional Info