-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Fix repo url with the correct default branch #6776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@snitin315 @chenxsan Could you take a look at this PR please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
(The Vercel deployment needs to be retry I think)
I guess it's the API rate limit issue. Unfortunately, I can't access the Vercel logs.
@chenxsan is attempting to deploy a commit to the Webpack Docs Team on Vercel. A member of the Team first needs to authorize it. |
Yeah, api limit. I've pushed a fix here #6797. |
@chenxsan I think it's fine. Perhaps, can you also invite me ( |
Sorry, I don't have the permission to invite, you'll have to ask sokra to invite you. |
The plugins and loaders documentation contains links to edit the page with the default branch set to
master
while it may have another value, e.g.main
.Example of broken url on the plugin svg-chunk-webpack-plugin (see
Edit this page
link at the bottom of the page)The PR gets the default branch for each repository from the GitHub API. The README url also takes this change into account.
Question, should the npm script "lint:links" found this 404?