Skip to content

Fix repo url with the correct default branch #6776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 2, 2023

Conversation

yoriiis
Copy link
Contributor

@yoriiis yoriiis commented Apr 25, 2023

The plugins and loaders documentation contains links to edit the page with the default branch set to master while it may have another value, e.g. main.

Example of broken url on the plugin svg-chunk-webpack-plugin (see Edit this page link at the bottom of the page)

https://github.com/yoriiis/svg-chunk-webpack-plugin/edit/master/README.md

The PR gets the default branch for each repository from the GitHub API. The README url also takes this change into account.


Question, should the npm script "lint:links" found this 404?

@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 0:06am

@yoriiis
Copy link
Contributor Author

yoriiis commented May 2, 2023

@snitin315 @chenxsan Could you take a look at this PR please?
(The Vercel deployment needs to be retry I think)

@snitin315 snitin315 closed this May 2, 2023
@snitin315 snitin315 reopened this May 2, 2023
Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

(The Vercel deployment needs to be retry I think)

I guess it's the API rate limit issue. Unfortunately, I can't access the Vercel logs.

@vercel
Copy link

vercel bot commented May 2, 2023

@chenxsan is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@chenxsan
Copy link
Member

chenxsan commented May 2, 2023

LGTM.

(The Vercel deployment needs to be retry I think)

I guess it's the API rate limit issue. Unfortunately, I can't access the Vercel logs.

Yeah, api limit. I've pushed a fix here #6797.

@chenxsan chenxsan merged commit 217eca7 into webpack:main May 2, 2023
@chenxsan
Copy link
Member

chenxsan commented May 2, 2023

Unfortunately we just introduced a side effect now because of the vercel environment variable:

Not sure I should disable it.

@snitin315
Copy link
Member

@chenxsan I think it's fine. Perhaps, can you also invite me ([email protected]) to the Vercel account so that I can also authorize these deployments?

@chenxsan
Copy link
Member

chenxsan commented May 3, 2023

@chenxsan I think it's fine. Perhaps, can you also invite me ([email protected]) to the Vercel account so that I can also authorize these deployments?

Sorry, I don't have the permission to invite, you'll have to ask sokra to invite you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants