docs(Configuration): document new devServer.overlay options #6809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malcolm-kee is attempting to deploy a commit to the Webpack Docs Team on Vercel. A member of the Team first needs to authorize it. |
malcolm-kee
commented
May 7, 2023
| @@ -19,7 +19,7 @@ Once you are in the project directory, run the following commands: | |||
| - `yarn build` to create a production version of the site. | |||
| - `yarn start` to develop on a local webpack-dev-server: [localhost:3000][3]. | |||
|
|
|||
| > NOTE: run `yarn fetch` before running `yarn start` command for the first time | |||
| > NOTE: run `yarn fetch-repos` and then `yarn fetch` before running `yarn start` command for the first time | |||
There was a problem hiding this comment.
I not sure if the better solution is to rename fetch-repos script to fetch:repos or update this docs, but definitely this is something that is outdated and blocking first time setup.
malcolm-kee
force-pushed
the
config/dev-server-overlay-options
branch
from
899a7f6 to
03eeeb0
Compare
malcolm-kee
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
snitin315
reviewed
May 8, 2023
|
@snitin315 Who should I tag to merge this? |
TheLarkInn
approved these changes
May 10, 2023
|
@chenxsan whats this authorization check I'm happy to force merge but unsure if this is okay? |
|
We need to ask @sokra to invite more team members to vercel so that we can also autherize deploy previews. |
|
This is good to merge. |
|
@TheLarkInn See
#6776 (comment).
We introduced a fix here #6797 to workaround api limit on vercel which results the authorization requirement.
Most of the time you can just merge if no other check failed.
…On Thursday, May 11, 2023, Sean Larkin ***@***.***> wrote:
@chenxsan <https://github.com/chenxsan> whats this authorization check
I'm happy to force merge but unsure if this is okay?
—
Reply to this email directly, view it on GitHub
<#6809 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIKPEBFQGHW3UGY7OBLCPLXFQTU5ANCNFSM6AAAAAAXY37DUE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves