Skip to content

Conversation

louisescher
Copy link
Member

Description (required)

Translate the whole tutorial into the German language

Related issues & labels (optional)

josefineschaefer and others added 13 commits April 4, 2024 15:15
* Create index in German.mdx

* Apply suggestions from code review

Co-authored-by: Because789 <[email protected]>

* fix description

---------

Co-authored-by: Because789 <[email protected]>
Co-authored-by: Yan <[email protected]>
* i18n(de): add 1-setup to german blog tutorial

Adding German translation to Blog tutorial.

* Apply suggestions from code review

Implement feedback from review.

Co-authored-by: Because789 <[email protected]>

* Fehlermeldung im Original 

Korrektur nach Feedback.

* Update src/content/docs/de/tutorial/1-setup/1.mdx

Co-authored-by: Because789 <[email protected]>

---------

Co-authored-by: Because789 <[email protected]>
Co-authored-by: Yan <[email protected]>
* add `3-components/index`

* Update index.mdx
* add `3-components/1`

* fixing typos round 1

* Update src/content/docs/de/tutorial/3-components/1.mdx

Co-authored-by: Timon Jurschitsch <[email protected]>

---------

Co-authored-by: Timon Jurschitsch <[email protected]>
Co-authored-by: Yan <[email protected]>
* add translation

* first batch of typos

* Update src/content/docs/de/tutorial/3-components/3.mdx

Co-authored-by: Timon Jurschitsch <[email protected]>

---------

Co-authored-by: Timon Jurschitsch <[email protected]>
* add `3-components/2.mdx`

* fix first batch of typos

---------

Co-authored-by: Yan <[email protected]>
Copy link

netlify bot commented Oct 5, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit db72b4d
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68e2af959f4b060008b7d81f
😎 Deploy Preview https://deploy-preview-12502--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 5, 2025
@louisescher louisescher changed the title De/tutorial i18n(de): tutorial Oct 5, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Oct 5, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/tutorial/0-introduction/1.mdx Localization removed, will be marked as missing.
de/tutorial/3-components/1.mdx Localization added, will be marked as complete.
de/tutorial/3-components/2.mdx Localization added, will be marked as complete.
de/tutorial/3-components/3.mdx Localization added, will be marked as complete.
de/tutorial/3-components/4.mdx Localization added, will be marked as complete.
de/tutorial/3-components/index.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@louisescher louisescher added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 5, 2025
Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve reviewed this PR and changed some formatting so it is more consistent with other tutorial‐related PRs being translated to German.

But what I’ve noticed is that there’s lots of inconsistency on which term to use. Maybe once all tutorial pages are done being translated, they should all be reviewed so it uses a consistent writing style.

---
---
<div class="nav-links">
<a href="/">Home</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what’s best: Startseite, Home or Homepage.

Copy link
Member Author

@louisescher louisescher Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think home is too bad to be honest

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Home is okay IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we go with "Startseite" which seems definitely more intuitive and better 👍

Suggested change
<a href="/">Home</a>
<a href="/">Startseite</a>

@randomguy-2650

This comment was marked as duplicate.

Copy link
Contributor

@randomguy-2650 randomguy-2650 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed something again to replace the “incorrect” quotes with the „correct ones“.

louisescher and others added 26 commits October 5, 2025 19:40
@trueberryless
Copy link
Contributor

Man, I wish that GitHub would already have implemented the "Add to batch" feature so everything could be applied in one commit...

@louisescher
Copy link
Member Author

louisescher commented Oct 5, 2025

image

Tell me about it. (On the file tab, it says the feature is "not available yet")

@trueberryless
Copy link
Contributor

Tell me about it. (On the file tab, it says the feature is "not available yet")

Exactly (sorry if I worded it ironically, but it was meant utterly serious...

@trueberryless
Copy link
Contributor

The file 3-components/4-mdx will be updated by #12515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants