-
Notifications
You must be signed in to change notification settings - Fork 4
Create cookies.md #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add Cookie Statement page explaining Able Player's use of functional cookies
Thank you @kurapativyshnavi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for writing this.
I added some comments with the code
On the page https://wpaccessibility.org/docs/contribute/documentation/ you can read how the code of a page is set up.
@joedolson can you please review the content itself?
As you know better how the Able player is set up.
docs/about/cookies.md
Outdated
description: Explanation of Able Player's use of functional cookies | ||
--- | ||
|
||
## 🍪 Cookie Statement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the icon, this is set up as formal documentation.
Also, start with an H1 -> # Cookie Statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a sentence about that no other cookies are used except for the cookies the Able player sets.
docs/about/cookies.md
Outdated
|
||
Able Player uses cookies to enhance accessibility and improve user experience. These cookies are **strictly functional**—they help remember your preferences, such as playback settings, but do **not** track your activity or collect personal data. | ||
|
||
### 🔧 What kind of cookies are used? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the icon
Change heading into an H2
docs/about/cookies.md
Outdated
|
||
All cookies are stored locally in your browser and are used **only** to maintain your settings between sessions. | ||
|
||
### 🚫 No tracking, no profiling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the icon
Change heading into an H2
Update cookies.md based on review feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a few changes so that the topic of the page is about how the website uses cookies. A cookie statement needs to be about how the site uses cookies, and address the specific cookies and types of cookies used. Even though there is only one part of the site that uses cookies, we need to do everything in reference to the site holistically.
### 🔧 What kind of cookies are used? | ||
## What kind of cookies are used? | ||
|
||
Able Player uses the [js-cookie](https://github.com/js-cookie/js-cookie) library to store and retrieve user preferences. These include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section should include information about the type of cookie: Essential, Performance, Functional, or Marketing. The Able Player cookies are classified as "Functional" - cookies to provide enhanced, personalized features such as remembering user choices and preferences.
docs/about/cookies.md
Outdated
### 🚫 No tracking, no profiling | ||
## No tracking, no profiling | ||
|
||
Able Player does **not** use cookies for advertising, analytics, or behavioral tracking. Your privacy is respected, and no information is shared with third parties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cookie statements should indicate how the site uses the cookies. So this should be about how wpaccessibility.org uses cookies, not about Able Player.
docs/about/cookies.md
Outdated
# Cookie Statement | ||
|
||
Able Player uses cookies to enhance accessibility and improve user experience. These cookies are **strictly functional**—they help remember your preferences, such as playback settings, but do **not** track your activity or collect personal data. | ||
Able Player uses cookies to enhance accessibility and improve user experience. These cookies are **strictly functional**—they help remember your preferences, such as playback settings, but do **not** track your activity or collect personal data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be about how wpaccessibility.org uses cookies. E.g. "wpaccessibility.org
uses cookies in its media player, Able Player. Able Player uses cookies to..."
Hey @kurapativyshnavi - You may want to merge changes from the latest Also cc @rianrietveld so once confirmed, we can close #100 |
Add Cookie Statement page explaining Able Player's use of functional cookies