Skip to content

pkg-config file is broken when CMAKE_INSTALL_LIBDIR is absolute #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexshpilkin opened this issue May 19, 2022 · 0 comments · Fixed by #750
Closed

pkg-config file is broken when CMAKE_INSTALL_LIBDIR is absolute #748

alexshpilkin opened this issue May 19, 2022 · 0 comments · Fixed by #750

Comments

@alexshpilkin
Copy link

alexshpilkin commented May 19, 2022 •
edited
Loading

As per title: xsimd.pc.in has

prefix=@CMAKE_INSTALL_PREFIX@
libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@

and so can’t handle absolute paths in CMAKE_INSTALL_LIBDIR. This leads to broken .pc files on NixOS in particular.

Identical to xtensor-stack/xtensor#2542. See “Concatenating paths when building pkg-config files” for a thorough discussion of the problem and a suggested fix, or KDE’s extra-cmake-modules for a simpler approach.
@alexshpilkin alexshpilkin mentioned this issue May 19, 2022
Open
serge-sans-paille added a commit that referenced this issue May 20, 2022
@serge-sans-paille
Get rid of libdir entry in xsimd.pc
7a49b48 
xsimd is a header-only library, so libdir is not useful

Fix #748
@serge-sans-paille serge-sans-paille mentioned this issue May 20, 2022
Merged
serge-sans-paille added a commit that referenced this issue May 20, 2022
@serge-sans-paille
Fix xsimd.pc paths
d1b0e14 
Accept both relative and absolute libdir and include dir

Fix #748
serge-sans-paille added a commit that referenced this issue May 24, 2022
@serge-sans-paille
Fix xsimd.pc paths
8f5b3b6 
Accept both relative and absolute libdir and include dir

Fix #748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix libdir entry in xsimd.pc xtensor-stack/xsimd
1 participant
@alexshpilkin