Fix libdir entry in xsimd.pc #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexshpilkin please correct me if libdir is actually needed. |
Accept both relative and absolute libdir and include dir Fix #748
serge-sans-paille
force-pushed
the
fix/pkg-config-libdir
branch
from
7a49b48 to
d1b0e14
Compare
ok, patch updated |
serge-sans-paille
changed the title
|
@JohanMabille / @alexshpilkin : ready for review |
alexshpilkin
reviewed
Jun 2, 2022
| @@ -1,6 +1,6 @@ | |||
| prefix=@CMAKE_INSTALL_PREFIX@ | |||
| libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@ | |||
| includedir=${prefix}/include | |||
| ibdir=@libdir_for_pc_file@ | |||
There was a problem hiding this comment.
@serge-sans-paille I’m very sorry for procrastinating on this, but there seems to be a typo here:
Suggested change
| ibdir=@libdir_for_pc_file@ | |
| libdir=@libdir_for_pc_file@ |
There was a problem hiding this comment.
@serge-sans-paille I’m very sorry for procrastinating on this, but there seems to be a typo here:
I'm very sorry for the typo :-/
Fixed as of ed0ad83
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xsimd is a header-only library, so libdir is not useful
Fix #748