Skip to content

adding GitHub Action for Creating a Release on Tag push #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

julianavmgiusti
Copy link

@julianavmgiusti julianavmgiusti commented Oct 19, 2022

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Fixes #1118

@sanketverma1704
Copy link
Member

Hi @julianavmgiusti. Thanks for the PR.
@jakirkham, please have a look.

@jakirkham
Copy link
Member

cc @joshmoore

@joshmoore
Copy link
Member

Thanks @julianavmgiusti! I'm not at my laptop for a day or two but my first questions would be: can this create a link to the release notes as the others do? and if someone creates a tag & release on the webpage will another get created?

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1204 (7ec952b) into main (8bd84fb) will increase coverage by 0.04%.
Report is 236 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
+ Coverage   99.94%   99.99%   +0.04%     
==========================================
  Files          35       35              
  Lines       13964    14136     +172     
==========================================
+ Hits        13957    14135     +178     
+ Misses          7        1       -6     
Files Coverage Δ
zarr/_storage/store.py 100.00% <100.00%> (ø)
zarr/_storage/v3.py 100.00% <100.00%> (ø)
zarr/attrs.py 100.00% <100.00%> (ø)
zarr/convenience.py 100.00% <ø> (ø)
zarr/core.py 100.00% <100.00%> (ø)
zarr/creation.py 100.00% <100.00%> (ø)
zarr/hierarchy.py 99.78% <100.00%> (ø)
zarr/indexing.py 100.00% <100.00%> (ø)
zarr/meta.py 100.00% <ø> (ø)
zarr/storage.py 100.00% <100.00%> (ø)
... and 12 more

@joshmoore
Copy link
Member

@julianavmgiusti: have you tested this out on your own repository?

@jhamman
Copy link
Member

jhamman commented Dec 7, 2023

This has unfortunately gone stale. Will it be revived or should we close this?

@jhamman jhamman added the stale label Dec 7, 2023
@jhamman
Copy link
Member

jhamman commented Feb 13, 2024

Closing this out as stale. We'll keep the original feature request open.

@jhamman jhamman closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding GitHub release publishing step (when tagging)
5 participants