Check untyped defs on v3 #1784
Merged
Check untyped defs on v3 #1784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
changed the title
|
unless anyone objects, I will hit the merge button later today |
Charoula-Kyriakides
added a commit
to Charoula-Kyriakides/zarr-python
that referenced
this pull request
Apr 13, 2024
Check untyped defs (zarr-developers#1784)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1783. This enables the
check_untyped_defsmypy rule, and makes some of the easiest fixes. For the tricker fixes, I added the files to the a mypy override list, and I think it's easiest if each of these is done in separate PRs so we can enable this rule now (to stop any more violations), but incrementally improve it.TODO: