Skip to content

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Aug 6, 2025

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Aug 6, 2025
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.54%. Comparing base (71cc0c2) to head (6f564d3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/zarr/core/array.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3346   +/-   ##
=======================================
  Coverage   94.54%   94.54%           
=======================================
  Files          78       78           
  Lines        9419     9419           
=======================================
  Hits         8905     8905           
  Misses        514      514           
Files with missing lines Coverage Δ
src/zarr/testing/stateful.py 98.29% <ø> (ø)
src/zarr/core/array.py 97.10% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b
Copy link
Contributor

d-v-b commented Aug 6, 2025

why is the coverage report giving us false positives here

@d-v-b d-v-b merged commit f087c56 into zarr-developers:main Aug 6, 2025
30 of 31 checks passed
@DimitriPapadopoulos
Copy link
Contributor Author

The single line of code I have modified to fix the the typo raises en exception and is not covered by a test.

@DimitriPapadopoulos DimitriPapadopoulos deleted the spelling branch August 6, 2025 10:04
@d-v-b
Copy link
Contributor

d-v-b commented Aug 6, 2025

The single line of code I have modified to fix the the typo raises en exception and is not covered by a test.

yes but your change did not reduce coverage, since that exception was not covered before. this seems like the important metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants