Skip to content

Test coverage CI #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

jrbourbeau
Copy link
Member

To see if we're below 100% on master

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • Docs build locally (e.g., run tox -e docs)
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@jakirkham
Copy link
Member

If you look at the Coveralls report, it lists files a few times. Some of these note 100% and some don't. Though the ones that don't typically have lines intentionally excluded (workarounds for old Python or NumPy versions). The cumulative result is 100% coverage. However it is curious that Coveralls no longer reports this correctly. I'm guessing they changed something, which is making cumulative coverage not work correctly. Not sure how though. Maybe this helps give you some context. 🙂

@jakirkham
Copy link
Member

This seems interesting.

Coverage.py warning: Couldn't read data from '/home/travis/build/zarr-developers/zarr-python/.coverage.travis-job-b9c4d5f1-3db6-48d9-b9c7-def15fa379e3.4893.462486': CoverageException: Doesn't seem to be a coverage.py data file
Coverage.py warning: Couldn't read data from '/home/travis/build/zarr-developers/zarr-python/.coverage.travis-job-b9c4d5f1-3db6-48d9-b9c7-def15fa379e3.4894.722251': CoverageException: Doesn't seem to be a coverage.py data file

ref: https://travis-ci.org/zarr-developers/zarr-python/jobs/610469624#L2314-L2315

@jrbourbeau
Copy link
Member Author

Thanks for the extra info, that does help provide more context. Mostly, I was surprised to see over in #503 two lines (here and here) which are seemingly unrelated to the changes in the PR become uncovered

@jakirkham
Copy link
Member

Yeah we might want to come up with a special coverage selector for NumPy version similar to what has been done with Python previously.

zarr-python/tox.ini

Lines 14 to 15 in c647de1

py35,py36,py37: PY_MAJOR_VERSION = py3
py27: PY_MAJOR_VERSION = py2

pragma: ${PY_MAJOR_VERSION} no cover

@jakirkham
Copy link
Member

Toggling for CI

@jakirkham jakirkham closed this Jan 18, 2020
@jakirkham jakirkham reopened this Jan 18, 2020
@jakirkham
Copy link
Member

Toggling for CI.

@jakirkham jakirkham closed this Jan 19, 2020
@jakirkham jakirkham reopened this Jan 19, 2020
@mzjp2
Copy link
Member

mzjp2 commented Mar 2, 2020

For some reason, coveralls just isn't being communicated with, but I can't tell why. Our .travis.yml is the same as always 🤷‍♂

@jakirkham
Copy link
Member

FWIW after poking at this problem occasionally over the past few months, I'm about as confused as you are.

Maybe we need to use the travis-pro configuration?

@mzjp2
Copy link
Member

mzjp2 commented Mar 2, 2020

Just FYI, I've removed the continuous-integration/travis-ci status check and enabled the other other one, based off it being depracated: https://travis-ci.community/t/known-issue-travis-ci-reports-expected-waiting-for-status-to-be-reported-on-the-github-status-api-but-the-status-never-arrives/1154

@mzjp2
Copy link
Member

mzjp2 commented Mar 2, 2020

Other people with the same problem: lemurheavy/coveralls-public#1408

@jakirkham
Copy link
Member

Some work to fix Coveralls in PR ( #541 ).

@jrbourbeau
Copy link
Member Author

Closing this PR in favor of #541. Thanks for working on this @mzjp2!

@jrbourbeau jrbourbeau closed this Mar 3, 2020
@jrbourbeau jrbourbeau deleted the coverage branch March 3, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants