-
-
Notifications
You must be signed in to change notification settings - Fork 329
Attempt to fix coveralls #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you able to see this page? |
That's the generic advice when not using a coveralls client like we are (hence the use of the |
FWIW I regenerated the token already 😉 It seems they mention |
It seems to say that it'll find the token automatically: 🤷♂ how it does that, I don't know
|
Aha, running
|
Good catch! Maybe we can update these lines? |
Co-Authored-By: jakirkham <[email protected]>
So they've all been reported to coveralls succesfully at least, but we're not getting the Github Status update. I might just merge this to master anyway and see if that helps any |
Happy with merging to |
Thanks for working on this @mzjp2! 😄 |
Bumping coverage a bit with PR ( #542 ). |
If you have a chance @mzjp2, would you be able to look at the numcodecs repo as well? Guessing it needs similar changes. |
Done @jakirkham, should be all good now, good spot. :) |
Wow! That was fast. Thanks Zain! 😄 |
Let's see if this works...
TODO: