Skip to content

Attempt to fix coveralls #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 3, 2020
Merged

Attempt to fix coveralls #541

merged 5 commits into from
Mar 3, 2020

Conversation

mzjp2
Copy link
Member

@mzjp2 mzjp2 commented Mar 2, 2020

Let's see if this works...

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@jakirkham
Copy link
Member

Are you able to see this page?

@mzjp2
Copy link
Member Author

mzjp2 commented Mar 2, 2020

From the Coveralls docs on Travis Pro, it says to do this..

First, if you are using Travis CI , make sure it's building correctly. If you're using Travis Pro, add the following lines to a .coveralls.yml file in your repository's root:

service_name: travis-pro
repo_token: f9ihk8Pur6zETkTohfPmOPwbEWrZTkKK8

That's the generic advice when not using a coveralls client like we are (hence the use of the .coveralls.yml file. We're using https://github.com/coveralls-clients/coveralls-python and they had this tip in their docs: https://coveralls-python.readthedocs.io/en/latest/usage/configuration.html

@jakirkham
Copy link
Member

FWIW I regenerated the token already 😉

It seems they mention COVERALLS_REPO_TOKEN should be set. We might need travis encrypt to obscure this value.

@mzjp2
Copy link
Member Author

mzjp2 commented Mar 2, 2020

It seems to say that it'll find the token automatically: 🤷‍♂ how it does that, I don't know

If coveralls-python is being run on TravisCI, it will automatically set the token for communication with coveralls.io. Otherwise, you should set the environment variable COVERALLS_REPO_TOKEN, which can be found on the dashboard for your project in coveralls.io:

@mzjp2
Copy link
Member Author

mzjp2 commented Mar 2, 2020

Aha, running coveralls debug in travis yields:

coverage.misc.CoverageException: Couldn't use data file '/home/travis/build/zarr-developers/zarr-python/.coverage': Looks like a coverage 4.x data file. Are you mixing versions of coverage?

@jakirkham
Copy link
Member

jakirkham commented Mar 2, 2020

Good catch! Maybe we can update these lines?

@mzjp2
Copy link
Member Author

mzjp2 commented Mar 2, 2020

So they've all been reported to coveralls succesfully at least, but we're not getting the Github Status update. I might just merge this to master anyway and see if that helps any

@mzjp2 mzjp2 marked this pull request as ready for review March 2, 2020 23:51
@mzjp2 mzjp2 self-assigned this Mar 2, 2020
@jakirkham
Copy link
Member

Happy with merging to master. Perhaps ( lemurheavy/coveralls-public#1408 ) is just indicating a service outage.

@jakirkham jakirkham mentioned this pull request Mar 3, 2020
7 tasks
@mzjp2 mzjp2 merged commit 3ae9439 into master Mar 3, 2020
@mzjp2 mzjp2 deleted the fix/coveralls branch March 3, 2020 02:40
@mzjp2
Copy link
Member Author

mzjp2 commented Mar 3, 2020

it works! :)

image

@jakirkham
Copy link
Member

Thanks for working on this @mzjp2! 😄

@jakirkham
Copy link
Member

Bumping coverage a bit with PR ( #542 ).

@jakirkham
Copy link
Member

If you have a chance @mzjp2, would you be able to look at the numcodecs repo as well? Guessing it needs similar changes.

@mzjp2
Copy link
Member Author

mzjp2 commented Mar 8, 2020

Done @jakirkham, should be all good now, good spot. :)

@jakirkham
Copy link
Member

Wow! That was fast. Thanks Zain! 😄

@Carreau Carreau added this to the v2.5 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants