Skip to content

Fsspec writing #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 3, 2020
Merged

Fsspec writing #630

merged 15 commits into from
Nov 3, 2020

Conversation

martindurant
Copy link
Member

@martindurant martindurant commented Oct 8, 2020

[Description of PR]

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • AppVeyor and Travis CI passes
  • Test coverage is 100% (Coveralls passes)

@codecov-io
Copy link

codecov-io commented Oct 8, 2020

Codecov Report

Merging #630 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #630   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines        10006     10040   +34     
=========================================
+ Hits         10006     10040   +34     
Impacted Files Coverage Δ
zarr/convenience.py 100.00% <100.00%> (ø)
zarr/core.py 100.00% <100.00%> (ø)
zarr/storage.py 100.00% <100.00%> (ø)
zarr/tests/test_storage.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06c3b40...2198438. Read the comment docs.

@martindurant martindurant marked this pull request as ready for review October 20, 2020 14:09
@martindurant
Copy link
Member Author

(more documentation to come)

@martindurant
Copy link
Member Author

(tagged three for review, one would do)

@Carreau
Copy link
Contributor

Carreau commented Nov 2, 2020

+1 feel free to merge, I did one suggestion, but otherwise LGTM.

@martindurant
Copy link
Member Author

Thanks, @Carreau

@martindurant martindurant merged commit c58bca4 into zarr-developers:master Nov 3, 2020
@martindurant martindurant deleted the fsspec_w branch November 3, 2020 15:05
@rabernat rabernat mentioned this pull request Nov 3, 2020
@Carreau Carreau added this to the v2.6 milestone Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants