Enable STM32L4R9i-disco DSI display via shield ST_B_DSI_MB1314 #86812

avolmat-st · 2025-03-08T21:29:03Z

This pull request includes updates, new driver and a new shield in order to enable the DSI display that can be mounted on the STM32L4R9I-DISCO board.
It enables both LTDC and DSI interfaces of the STM32L4R9 and for that purpose require the usage of the PLLSAI.

PLLSAI support isn't yet merged. There is another ongoing pull request for that purpose which can be found here:
#85135
The PLLSAI pull-request is still evolving hence this new pull-request will be rebased afterward once the PLLSAI will be merged.

Since it rely on another pull-request, it won't build (missing pllsai nodes or macros) but I am already pushing this one in order to start the review process.

boards/shields/st_b_dsi_mb1314/st_b_dsi_mb1314.conf

boards/shields/st_b_dsi_mb1314/st_b_dsi_mb1314.overlay

drivers/display/Kconfig.g1120tb101

drivers/display/display_stm32_ltdc.c

drivers/display/display_g1120tb101.c

drivers/display/display_stm32_ltdc.c

github-actions · 2025-05-17T00:37:24Z

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

avolmat-st · 2025-08-18T20:17:01Z

Added DSI connector in order to have shield overlay + board overlay and added doc folder.

This is to be used on top of PR #85135 which add support for PLLSAI and has been tested using the display sample app:

west build -p -b stm32l4r9i_disco --shield st_b_dsi_mb1314 samples/drivers/display/

avolmat-st · 2025-08-29T14:00:49Z

Triggered again the test to allow proper building since now PLLSAI support has been merged.
Tested ok merged on latest main branch using

west build -p -b stm32l4r9i_disco --shield st_b_dsi_mb1314 samples/drivers/display/

boards/shields/st_b_dsi_mb1314/boards/stm32l4r9i_disco.overlay

boards/shields/st_b_dsi_mb1314/doc/image.jpg

boards/shields/st_b_dsi_mb1314/doc/mb1314.jpg

avolmat-st · 2025-09-13T16:23:13Z

Added a new test for this shield. Retested ok with latest push of PR #95299, both PRs merged on top of main branch

avolmat-st · 2025-09-13T18:27:50Z

Twister failure is due to the need to have this PR applied on top of the PR #95299.

outdated

Add support for the GVO G1120TB101 DSI Panel. Signed-off-by: Alain Volmat <[email protected]>

Rely on the pixel format defined within the display node in order to configure the DSI interface pixel format. Signed-off-by: Alain Volmat <[email protected]>

Use the macro DISPLAY_BITS_PER_PIXEL in order to compute each format BPP and thus avoid requiring each format BPP written within the driver. Thanks to that, simply the function stm32_ltdc_set_pixel_format to avoid code duplication. Signed-off-by: Alain Volmat <[email protected]>

Addition of the STM32_SRC_HSE define in stm32l4_clock.h in order to be able to address the HSE clock source from the device-tree. Signed-off-by: Alain Volmat <[email protected]>

stm32l4r9 series embeds a MIPI DSI controller which uses the LTDC controller as input. Signed-off-by: Alain Volmat <[email protected]>

ltdc controller is also available in stm32l4r5 and stm32l4q5 so add it within stm32l4p5. It is not available in stm32l4r5 hence delete the node for this platform. Signed-off-by: Alain Volmat <[email protected]>

Add the description of the DSI connector available on the stm32l4r9i_disco board and zephyr_mipi_dsi/zephyr_lcd_controller alias to be used by display shields. Signed-off-by: Alain Volmat <[email protected]>

Addition of a new shield which embeds a round DSI display gvo,g1120tb101 of 390x390 pixels, with a touchpanel. This shield enables it via usage of the LTDC and DSI of the STM32. Touchpanel isn't yet supported in this commit and will be added later on in an additional commit. Signed-off-by: Alain Volmat <[email protected]>

Addition of tests with the st_b_dsi_mb1314 shield. Signed-off-by: Alain Volmat <[email protected]>

avolmat-st · 2025-09-19T19:03:05Z

Rebased on top of main branch now that PR #95299 is merged. Only corrected panel CMakefile & Kconfig conflicts due to the fact that another panel got merged in between.

sonarqubecloud · 2025-09-19T19:07:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

JarmouniA · 2025-09-19T22:20:38Z

drivers/display/display_g1120tb101.c

+{
+	uint8_t InitParam1[4] = {0x00, 0x04, 0x01, 0x89};
+	uint8_t InitParam2[4] = {0x00, 0x00, 0x01, 0x85};
+	int ret, i;


Suggested change

int ret, i;

int ret;

int i;

Is your proposal related to MISRA rule about multiple declaration within the same line ?
(A declaration should not declare more than one variable or member variable)

I am not sure this is considered as a requirement in Zephyr CodyingStyle and doesn't seem to be listed in required rule right ? (doc/contribute/coding_guidelines/index.rst)

Is your proposal related to MISRA rule about multiple declaration within the same line ? (A declaration should not declare more than one variable or member variable)

Yes, and it's more readable in my opinion. Non blocking though.

I am not sure this is considered as a requirement in Zephyr CodyingStyle and doesn't seem to be listed in required rule right ? (doc/contribute/coding_guidelines/index.rst)

Yes I think it's not.

JarmouniA · 2025-09-19T22:27:41Z

dts/arm/st/l4/stm32l4p5.dtsi

+			reg = <0x40016800 0x200>;
+			interrupts = <91 0>, <92 0>;
+			interrupt-names = "ltdc", "ltdc_er";
+			clocks = <&rcc STM32_CLOCK(APB2, 26U)>;


Suggested change

clocks = <&rcc STM32_CLOCK(APB2, 26U)>;

clocks = <&rcc STM32_CLOCK(APB2, 26)>;

Removing as well from the reset properties since it isn't necessary as well.

JarmouniA · 2025-09-19T22:33:24Z

dts/arm/st/l4/stm32l4r9.dtsi

+			#size-cells = <0>;
+			reg = <0x40016c00 0x800>;
+			clock-names = "dsiclk", "refclk", "pixelclk";
+			clocks = <&rcc STM32_CLOCK(APB2,  27U)>,


Suggested change

clocks = <&rcc STM32_CLOCK(APB2, 27U)>,

clocks = <&rcc STM32_CLOCK(APB2, 27)>,

Removing as well from the reset properties since it isn't necessary as well.

JarmouniA · 2025-09-19T22:58:28Z

drivers/display/Kconfig.g1120tb101

+# SPDX-License-Identifier: Apache-2.0
+
+config G1120TB101
+	bool "G1120TB101 display controller"


The panel controller is actually RM67162
https://community.st.com/ysqtg83639/attachments/ysqtg83639/mcu-boards-hardware-tools-forum/8521/3/Visionox-8-10-2017-G1120TB103GF-001A.pdf
And the panel is G1120TB103GF-001

Ouch ... THANKS for spotting this.
I also checked again, I originally based this on the Cube Example but mixed up the panel / controller.
This changes things since the RM67162 is actually already supported with a driver in Zephyr so I will rework this part of the PR.

zephyrbot added area: MIPI-DSI area: Clock Control area: Shields Shields (add-on boards) area: Display platform: STM32 ST Micro STM32 area: Devicetree labels Mar 8, 2025

zephyrbot requested review from avisconti, danieldegrasse, decsny, djiatsaf-st, erwango, FRASTM, galak, gautierg-st, GeorgeCGV, jfischer-no, kartben, marwaiehm-st, mathieuchopstm, mbolivar and rruuaanng March 8, 2025 21:29

zephyrbot assigned kartben Mar 8, 2025

JarmouniA previously requested changes Mar 8, 2025

View reviewed changes

decsny removed their request for review March 11, 2025 17:35

kartben assigned erwango and unassigned kartben Mar 12, 2025

mathieuchopstm reviewed Mar 17, 2025

View reviewed changes

drivers/display/display_g1120tb101.c Outdated Show resolved Hide resolved

drivers/display/display_stm32_ltdc.c Outdated Show resolved Hide resolved

avolmat-st mentioned this pull request Apr 24, 2025

Contributor nomination - Alain Volmat - ST #89005

Closed

github-actions bot added the Stale label May 17, 2025

avolmat-st force-pushed the st_b_dsi_mb1314 branch from a6cc95a to 7bf2689 Compare August 18, 2025 20:13

avolmat-st marked this pull request as ready for review August 18, 2025 20:17

avolmat-st requested review from JarmouniA and mathieuchopstm August 29, 2025 11:13

JarmouniA reviewed Aug 29, 2025

View reviewed changes

boards/shields/st_b_dsi_mb1314/boards/stm32l4r9i_disco.overlay Outdated Show resolved Hide resolved

boards/shields/st_b_dsi_mb1314/doc/image.jpg Outdated Show resolved Hide resolved

boards/shields/st_b_dsi_mb1314/doc/mb1314.jpg Outdated Show resolved Hide resolved

avolmat-st marked this pull request as draft August 31, 2025 20:43

avolmat-st force-pushed the st_b_dsi_mb1314 branch from 7bf2689 to f885e6a Compare September 1, 2025 19:46

avolmat-st marked this pull request as ready for review September 1, 2025 19:46

zephyrbot requested a review from nordic-krch September 13, 2025 16:23

Alain Volmat added 9 commits September 19, 2025 20:56

display: addition of GVO G1120TB101 DSI panel

14bf0c2

Add support for the GVO G1120TB101 DSI Panel. Signed-off-by: Alain Volmat <[email protected]>

mipi_dsi: stm32: use mdev pixfmt to configure DSI interface

64e970e

Rely on the pixel format defined within the display node in order to configure the DSI interface pixel format. Signed-off-by: Alain Volmat <[email protected]>

dt-bindings: clock: stm32l4: addition of HSE clock source

f9e817b

Addition of the STM32_SRC_HSE define in stm32l4_clock.h in order to be able to address the HSE clock source from the device-tree. Signed-off-by: Alain Volmat <[email protected]>

dts: st: l4: stm32l4r9: addition of mipi_dsi node

e40131e

stm32l4r9 series embeds a MIPI DSI controller which uses the LTDC controller as input. Signed-off-by: Alain Volmat <[email protected]>

dts: arm: stm32l4: add ltdc in stm32l4p5 and stm32l4q5

b21f537

ltdc controller is also available in stm32l4r5 and stm32l4q5 so add it within stm32l4p5. It is not available in stm32l4r5 hence delete the node for this platform. Signed-off-by: Alain Volmat <[email protected]>

boards: st: add DSI connector and display alias in stm32l4r9i_disco

9c92373

Add the description of the DSI connector available on the stm32l4r9i_disco board and zephyr_mipi_dsi/zephyr_lcd_controller alias to be used by display shields. Signed-off-by: Alain Volmat <[email protected]>

tests: display: display_check: add st_b_dsi_mb1314 shield

62d6a56

Addition of tests with the st_b_dsi_mb1314 shield. Signed-off-by: Alain Volmat <[email protected]>

avolmat-st force-pushed the st_b_dsi_mb1314 branch from 0565eeb to 62d6a56 Compare September 19, 2025 19:01

avolmat-st requested a review from JarmouniA September 19, 2025 19:03

JarmouniA approved these changes Sep 19, 2025

View reviewed changes

JarmouniA requested changes Sep 19, 2025

View reviewed changes

avolmat-st marked this pull request as draft September 20, 2025 06:51

	clocks = <&rcc STM32_CLOCK(APB2, 26U)>;
	clocks = <&rcc STM32_CLOCK(APB2, 26)>;

	clocks = <&rcc STM32_CLOCK(APB2, 27U)>,
	clocks = <&rcc STM32_CLOCK(APB2, 27)>,

Enable STM32L4R9i-disco DSI display via shield ST_B_DSI_MB1314 #86812

Are you sure you want to change the base?

Enable STM32L4R9i-disco DSI display via shield ST_B_DSI_MB1314 #86812

Conversation

avolmat-st commented Mar 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented May 17, 2025

Uh oh!

avolmat-st commented Aug 18, 2025

Uh oh!

avolmat-st commented Aug 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

avolmat-st commented Sep 13, 2025

Uh oh!

avolmat-st commented Sep 13, 2025

Uh oh!

avolmat-st commented Sep 19, 2025

Uh oh!

sonarqubecloud bot commented Sep 19, 2025

Quality Gate passed

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!