Skip to content

Remove callconv(.Cold), but keep it as an implementation detail #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tadeokondrak opened this issue Oct 4, 2020 · 0 comments · Fixed by #6596
Closed

Remove callconv(.Cold), but keep it as an implementation detail #6556

tadeokondrak opened this issue Oct 4, 2020 · 0 comments · Fixed by #6596
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone

Comments

@tadeokondrak
Copy link
Contributor

tadeokondrak commented Oct 4, 2020

This is an LLVM-specific calling convention which is not guaranteed to be stable, but Zig currently treats it as any other stable calling convention.

I don't think there's a reason to expose this, when instead it could just be automatically used for @setCold(true) functions.

No code in the Zig repo uses this calling convention.

@alexnask alexnask added the proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. label Oct 4, 2020
@Vexu Vexu added this to the 0.8.0 milestone Oct 5, 2020
@andrewrk andrewrk added the accepted This proposal is planned. label Oct 5, 2020
tadeokondrak added a commit to tadeokondrak/zig that referenced this issue Oct 7, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This isn't a stable, defined calling convention, so it shouldn't be
grouped in with the others.

Closes ziglang#6556
andrewrk pushed a commit that referenced this issue Oct 7, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This isn't a stable, defined calling convention, so it shouldn't be
grouped in with the others.

Closes #6556
@Vexu Vexu modified the milestones: 0.8.0, 0.7.0 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants