Skip to content

Remove callconv(.Cold), but keep it as an implementation detail #6556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tadeokondrak opened this issue Oct 4, 2020 · 0 comments · Fixed by #6596
Closed

Remove callconv(.Cold), but keep it as an implementation detail #6556

tadeokondrak opened this issue Oct 4, 2020 · 0 comments · Fixed by #6596
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.7.0

Comments

@tadeokondrak
Copy link
Contributor

tadeokondrak commented Oct 4, 2020 •
edited
Loading

This is an LLVM-specific calling convention which is not guaranteed to be stable, but Zig currently treats it as any other stable calling convention.

I don't think there's a reason to expose this, when instead it could just be automatically used for @setCold(true) functions.

No code in the Zig repo uses this calling convention.
@alexnask alexnask added the proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. label Oct 4, 2020
@Vexu Vexu added this to the 0.8.0 milestone Oct 5, 2020
@andrewrk andrewrk added the accepted This proposal is planned. label Oct 5, 2020
tadeokondrak added a commit to tadeokondrak/zig that referenced this issue Oct 7, 2020
@tadeokondrak
Remove .Cold calling convention.

Verified

This commit was signed with the committer’s verified signature.
tadeokondrak Tadeo Kondrak
GPG key ID: D41E092CA43F1D8B
Verified
Learn about vigilant mode
247f64a 
This isn't a stable, defined calling convention, so it shouldn't be
grouped in with the others.

Closes ziglang#6556
@tadeokondrak tadeokondrak mentioned this issue Oct 7, 2020
Merged
andrewrk pushed a commit that referenced this issue Oct 7, 2020
@tadeokondrak @andrewrk
Remove .Cold calling convention.
0a6863a 
This isn't a stable, defined calling convention, so it shouldn't be
grouped in with the others.

Closes #6556
@Vexu Vexu modified the milestones: 0.8.0, 0.7.0 Oct 12, 2020
@lambdadog lambdadog mentioned this issue Sep 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Remove .Cold calling convention. tadeokondrak/zig
4 participants
@andrewrk @alexnask @tadeokondrak @Vexu