Skip to content

Remove .Cold calling convention. #6596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

tadeokondrak
Copy link
Contributor

This isn't a stable, defined calling convention, so it shouldn't be
grouped in with the others.

Closes #6556


I said "keep it as an implementation detail" in the original issue, but it seems like ZigLLVMAddFunctionAttrCold doesn't change the calling convention.
I think using the cold calling convention for .Unspecified calling convention functions which are @setCold(true) can be a different PR.

Verified

This commit was signed with the committer’s verified signature.
tadeokondrak Tadeo Kondrak
This isn't a stable, defined calling convention, so it shouldn't be
grouped in with the others.

Closes ziglang#6556
@andrewrk andrewrk merged commit 0a6863a into ziglang:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove callconv(.Cold), but keep it as an implementation detail
2 participants