Skip to content

fixed 'update node registration' get/parse body bytes #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

iltoga
Copy link
Contributor

@iltoga iltoga commented Aug 14, 2019

Description

fixes new and update registration process by adding new tx type to transaction.go and removing registration height from (new) node registration tx body

Breakdown

  • Recompiled Updated schema: removed registration height field from (new) noderegistration tx body
  • Added tx type 2,1 (update node registration) to transaction.go and added unit test for it
  • Fixed new and update node registration get/parse body bytes and fixed/implemented new tests

Reference Issue

Close #84

Sorry, something went wrong.

…registration tx body

fixed 'update node registration' get/parse body bytes and fixed/implemented new tests
@iltoga iltoga requested a review from andy-shi88 August 14, 2019 02:35
@iltoga iltoga self-assigned this Aug 14, 2019
@iltoga iltoga added this to the Sprint 3 milestone Aug 14, 2019
@andy-shi88 andy-shi88 merged commit 24dd5c1 into develop Aug 14, 2019
@andy-shi88 andy-shi88 deleted the 84-update-node-registration-add-txtype branch August 14, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tech: update node registration - transaction's business logic for 'update node registration' transaction type
2 participants