Add port field node registry #296
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node Address message for bold clarification of
NodeRegistration.NodeAddress
, which is now has:And affected
NodeRegistrationTransactionBody
,NodeRegistrationUpdateTransactionody
, and updated some packages was affected too. By Now to get extract NodeAddress to fully string node address need to callNodeRegistrationQuery.ExtractNodeAddress
, and also can build as NodeAddress struct useNodeRegsitrationQuery.BuildNodeAddress
Notes
make sure scan row or rows use
NodeRegistrationQuery.BuildModel
orNodeRegistrationQuery.Scan
Breakdown
NodeAddress
brand new fieldsReference Issue
Close #289
Depend on zoobc/zoobc-schema#65
Step to Test (optional)
go test ./...