Skip to content

Conversation

astaphobia
Copy link
Contributor

@astaphobia astaphobia commented Oct 3, 2019

Description

Node Address message for bold clarification of NodeRegistration.NodeAddress, which is now has:

message NodeAddress {
   Address string
   Port uint32
}

And affected NodeRegistrationTransactionBody, NodeRegistrationUpdateTransactionody, and updated some packages was affected too. By Now to get extract NodeAddress to fully string node address need to call NodeRegistrationQuery.ExtractNodeAddress, and also can build as NodeAddress struct use NodeRegsitrationQuery.BuildNodeAddress

Notes

make sure scan row or rows use NodeRegistrationQuery.BuildModel or NodeRegistrationQuery.Scan

Breakdown

  • NodeAddress brand new fields
  • Updating affected packages
  • Updated Test cases

Reference Issue

Close #289
Depend on zoobc/zoobc-schema#65

Step to Test (optional)

go test ./...

@astaphobia astaphobia added this to the Sprint 6 milestone Oct 3, 2019
@astaphobia astaphobia self-assigned this Oct 3, 2019
@andy-shi88 andy-shi88 modified the milestones: Sprint 6, Sprint 7 Oct 3, 2019
@andy-shi88 andy-shi88 merged commit bad82d9 into develop Oct 7, 2019
@andy-shi88 andy-shi88 deleted the add-port-field-node-registry branch October 7, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance: Add port field in Node Registry model
5 participants