357/359/377 - bug fixes #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-shi88
reviewed
Oct 25, 2019
| } | ||
| } else { | ||
| forkBlocks = append(forkBlocks, block) | ||
|
|
There was a problem hiding this comment.
should there be special handle once notice fork block is pushed? I mean if we already notice a single fork block, that mean we won't be able to validate the rest of the block anymore right? but this is just an open question, I'm not sure about the overall implementation regarding the fork process.
There was a problem hiding this comment.
nice catch! I have handled it by breaking from the loop. Thank you
capt4ce
changed the title
|
please fix the tests, and update base branch. @capt4ce |
|
@andy-shi88 Just fixed the failed CI. Please kindly check it again |
andy-shi88
approved these changes
Oct 28, 2019
astaphobia
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug fixes related to download blockchain and rollback
Breakdown
Reference Issue
Close #359 #357 #377
Step to Test (optional)