Skip to content

39/transaction send money #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jul 17, 2019
Merged

39/transaction send money #67

merged 35 commits into from
Jul 17, 2019

Conversation

astaphobia
Copy link
Contributor

Description

Fix bugs there are in sendMoney validation, ApplyConfirmed, ApplyUnconfirmed logic. depend on #14

Breakdown

  • Validate
  • ApplyConfirmed
  • ApplyUnconfirmed

Reference Issue

Close #66

Step to Test (optional)

go test ./... -v

astaphobia added 30 commits July 11, 2019 18:41
@astaphobia
this commit to initiate transaction builder that for implement apply,…
9aa3b93 
… unconfirm and validate tx
@astaphobia
Merge branch 'develop' of github.com:zoobc/zoobc-core into 39/transac…
37f2836 
…tion-send-money
@astaphobia
this commit to add account balance query
b5ededb
@astaphobia
this commit to validate spendablebalance with amount
9de3458
@astaphobia
Merge branch 'develop' of github.com:zoobc/zoobc-core into 39/transac…
00296cd 
…tion-send-money
@astaphobia
this commit to add func CreateAccountID from address and accountType
f920179
@astaphobia
this commit to initiate transaction implementation
4b2dbe1
@astaphobia
this commit to add update and insert query builder of account balance
3b641c5
@astaphobia
Merge branch 'develop' of github.com:zoobc/zoobc-core into 39/transac…
1f29dbf 
…tion-send-money
@astaphobia
this commit to modified insertAccountBalanceQuery
f49b3ba
@astaphobia
this commit to add insertAccountQuery
42bb84b
@astaphobia
this commit to add empty transaction
42b2cbe
@astaphobia
this commit to add func CreateAccountIDFromAddress
23862b6
@astaphobia
this commit to add sendMoney action
bb7cea4
@astaphobia
Merge branch 'develop' of github.com:zoobc/zoobc-core into 39/transac…
620e9b9 
…tion-send-money
@astaphobia
Merge branch 'develop' of github.com:zoobc/zoobc-core into 39/transac…
74713ec 
…tion-send-money
@astaphobia
fix golangci
e7c8073
@astaphobia
Func NewAccountBalanceQuery included on interface for test purpose
036fe79
@astaphobia
this commit to modified GetTransactionType func
e2ba7cf
@astaphobia
this commit to make sure coverage test
43cfb21
@astaphobia
NewAccountQuery include in interface
15483b6
@astaphobia
this commit to add test cases sendMoney func
ee6e6a5
@astaphobia
this commit to fix affected modification
14e3cf5
@astaphobia
this commit to fixing and modified
b9ff098
@astaphobia
remove unused declaration named
a26e42e
@astaphobia
remove unused declaration named
693fc41
@astaphobia
this commit to use util.ConvertUint32ToBytes() instead of manual convert
7f5f4f4
@astaphobia
this commit to fixing and modified
536ab64
@astaphobia
this commit to fixing auto import
9a28ecc
@astaphobia
update min-complexity
59adcd2
@astaphobia astaphobia added the BUG Something isn't working label Jul 17, 2019
@astaphobia astaphobia added this to the Sprint 1 milestone Jul 17, 2019
@astaphobia astaphobia self-assigned this Jul 17, 2019
@iltoga iltoga merged commit 0392453 into develop Jul 17, 2019
@astaphobia astaphobia deleted the 39/transaction-send-money branch July 17, 2019 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iltoga iltoga iltoga approved these changes

@capt4ce capt4ce Awaiting requested review from capt4ce

@andy-shi88 andy-shi88 Awaiting requested review from andy-shi88

Assignees

@astaphobia astaphobia

Labels
BUG Something isn't working
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

Tech: Send Money Transaction Type
2 participants
@astaphobia @iltoga