Skip to content

Tech: basic mempool implementation. Transaction validation and selection for block creation process #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iltoga opened this issue Jul 2, 2019 · 0 comments · Fixed by #65
Assignees
Labels
FEATURE New feature or request
Milestone

Comments

@iltoga
Copy link
Contributor

iltoga commented Jul 2, 2019

depends on #20

@iltoga iltoga added this to the Sprint 1 milestone Jul 2, 2019
@andy-shi88 andy-shi88 added the FEATURE New feature or request label Jul 4, 2019
iltoga pushed a commit that referenced this issue Jul 10, 2019
andy-shi88 pushed a commit that referenced this issue Jul 11, 2019
iltoga pushed a commit that referenced this issue Jul 12, 2019
iltoga pushed a commit that referenced this issue Jul 12, 2019
@andy-shi88 andy-shi88 mentioned this issue Jul 17, 2019
12 tasks
astaphobia pushed a commit that referenced this issue Jul 17, 2019
* #20 added timestamp to transaction table and simplified mempool table structure

* #14 - WIP: started implementing mempoolService

* #14 - WIP: still implementing mempoolservice and mempoolQuery

* fixed GetMempoolTransaction query

* #6 add executeTransactionStatements method to handle multiple query statement

* #6 add get transaction bytes and parse transaction bytes method

* #6 update transaction model

* #6 handle no-recipient get transaction bytes

* #6 update doc : add transaction bytes structure

* implementation of mempoolCoreService

* #14 tested GetMempoolTransactions,  AddMempoolTransaction, RemoveMempoolTransaction

* #14 completed testing mempool service

* start integrating mempool service into main process and blockchainprocessor

* added tx timeout (mempool tx expiration time)

* added getamount and getsize to transaction,TypeAction
added logic to pass in payload to blockchainprocessor when generating blocks

* small variable name refactoring, as suggested by code linter, to avoid confusion

* recompiled schema

* fixed comments

* removed unused interface signature

* added missing interface signature

* fixed logic error in tx GetSize for SendMoney tx (we are getting only body length, not full tx length)

* fixed some lint issues

* refactored part of mempoolService: moved removemempooltransactions to blockservice because part of PushBlock method
fixed unit tests
added to transactionUtil function to calculate transaction ID from transaction model

* refactored old unit tests (64 bytes signature instead of 256)
added tests for GetTransactionID

* merged develop with branch
fixed parse transaction bytes: added checks if bytes we are parsing are formally correct while reading them

* merged develop into branch

* resolved some of the comments from the PR
fixed relative tests

* added transactionQuery interface to blockservice and added insertTransaction to pushblock

* fixed NewBlock: was missing payloadlength
fixed bug in GenerateBlock: wrong variable scope
fixed unit tests

* removed comment relative to mempool table name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants