75 generalise tx validation #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
July 22, 2019 12:02
…xing bug in accountBalance request message
added new tx type for node registration (2,0) WIP: implementation of (new) nodeRegistration transaction workflow refactored some noderegistration query fixed accountBalanceQuery: missing interface signature for ExtractModel and missing method for BuildModel recompiled schema
moved transactionUtil functions to common separated generic tx from txType-specific validation logic WIP: noderegistration txType
andy-shi88
approved these changes
Jul 23, 2019
astaphobia
approved these changes
Jul 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate Transaction's validation logic that is generic (for all tx types) from the tx type-specific
Breakdown
Reference Issue
Close #75
Step to Test (optional)