Skip to content

Offer "Open links with in-app browser" setting #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Dec 27, 2024 · 3 comments · Fixed by #1400
Closed

Offer "Open links with in-app browser" setting #1228

chrisbobbe opened this issue Dec 27, 2024 · 3 comments · Fixed by #1400
Assignees
@PIG208
Labels
beta feedback Things beta users have specifically asked for
Milestone
M5b: Launch goals

Comments

@chrisbobbe
Copy link
Collaborator

Like we do in the legacy apps.

An instance of:
@chrisbobbe chrisbobbe added the beta feedback Things beta users have specifically asked for label Dec 27, 2024
@chrisbobbe chrisbobbe mentioned this issue Dec 27, 2024
Closed
@chrisbobbe
Copy link
Collaborator Author

This setting was requested in beta feedback on CZO.

@gnprice gnprice added this to the M5: Launch milestone Dec 28, 2024
@AshutoshKhadse23
Copy link

Hello
I would like to work on it

issue.1228.android.mp4

The link open now inside the app, so in addition would you want the setting to turn it on or off ?
And where ? Like the setting should be inside the 3 horizontal line or somewhere else?

@chrisbobbe
Copy link
Collaborator Author

As I noted on #1139:

Storing some client settings is #97, and I see a core team member (@PIG208) has just self-assigned that issue. So let's wait to work on this until he implements a settings UI where this setting will go.

The same applies here.

@PIG208 PIG208 mentioned this issue Feb 25, 2025
Merged
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Feb 25, 2025
@PIG208
settings: Add browser preference setting ui
6a58054 
The translation for the label is taken from zulip-mobile.

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 4, 2025
@PIG208
settings: Add browser preference setting ui
3dbd2ea 
The translation for the label is taken from zulip-mobile.

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 4, 2025
@PIG208
settings: Add browser preference setting ui
0cca6e7 
The translation for the label is taken from zulip-mobile.

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 4, 2025
@PIG208
settings: Add browser preference setting ui
20349a1 
The translation for the label is taken from zulip-mobile.

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 5, 2025
@PIG208
settings: Add browser preference setting ui
15df1d9 
The translation for the label is taken from zulip-mobile.

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 5, 2025
@PIG208
settings: Add browser preference setting ui
199df7c 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 6, 2025
@PIG208
settings: Add browser preference setting ui
2edb2ba 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 6, 2025
@PIG208
settings: Add browser preference setting ui
10acb77 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 10, 2025
@PIG208
settings: Add browser preference setting ui
e26481b 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 11, 2025
@PIG208
settings: Add browser preference setting ui
19e13be 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 11, 2025
@PIG208
settings: Add browser preference setting ui
20deb8b 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 11, 2025
@PIG208
settings: Add browser preference setting ui
f6a22b7 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
@PIG208 PIG208 mentioned this issue Mar 11, 2025
Merged
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 12, 2025
@PIG208
settings: Add browser preference setting ui
f0f7679 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 12, 2025
@PIG208
settings: Add browser preference setting ui
3ec51af 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 12, 2025
@PIG208
settings: Add browser preference setting ui
85c0d5b 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
gnprice pushed a commit to PIG208/zulip-flutter that referenced this issue Mar 13, 2025
@PIG208 @gnprice
settings: Add browser preference setting ui
36d1c6f 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 13, 2025
@PIG208
settings: Add browser preference setting ui
fe06129 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
gnprice pushed a commit to PIG208/zulip-flutter that referenced this issue Mar 14, 2025
@PIG208 @gnprice
settings: Add browser preference setting ui
a8e9028 
The translation for the label is taken from zulip-mobile. The user
facing string refers to "in in-app browser" when the actual value is
`UrlLaunchMode.platformDefault`. This is consistent with the behavior
the user sees when the link is a HTTP URL on Android and iOS, which
should cover the majority of use cases of this setting (and probably
what the user would expect).

The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 14, 2025
@PIG208
settings: Add browser preference setting ui
36a3534 
The UI currently does not have a design, and is made to be as simple as
possible to implement for now.

Fixes: zulip#1228

Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PIG208 PIG208

Labels
beta feedback Things beta users have specifically asked for
Projects
Flutter app
Status: Done
Milestone
M5b: Launch goals
Development

Successfully merging a pull request may close this issue.

Support setting browser preference PIG208/zulip-flutter
4 participants
@gnprice @chrisbobbe @PIG208 @AshutoshKhadse23