Skip to content

i18n: Allow selecting a different language than device setting #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrisbobbe opened this issue Dec 11, 2024 · 8 comments · May be fixed by #1513
Open

i18n: Allow selecting a different language than device setting #1139

chrisbobbe opened this issue Dec 11, 2024 · 8 comments · May be fixed by #1513
Labels
a-i18n Translation, localization, internationalization beta feedback Things beta users have specifically asked for

Comments

@chrisbobbe
Copy link
Collaborator

Currently, the app UI follows the device setting for what language it should try to display in.

This issue is for an in-app setting to choose any language we have translations for, instead of always following the device.

An instance of:

@chrisbobbe chrisbobbe added a-i18n Translation, localization, internationalization beta feedback Things beta users have specifically asked for labels Dec 11, 2024
@chrisbobbe chrisbobbe added this to the M5: Launch milestone Dec 11, 2024
@Gaurav-Kushwaha-1225
Copy link
Contributor

Hi @chrisbobbe,

This storing of some client settings isn't yet implemented for Theme Switching among dark/light/system.
Am I right?

If yes. Then, where we might add this feature for language now and theme later on.
I would suggest keeping it here, in the menu button.

Thank you.

@chrisbobbe
Copy link
Collaborator Author

Hi @Gaurav-Kushwaha-1225, welcome! Storing some client settings is #97, and I see a core team member (@PIG208) has just self-assigned that issue. So let's wait to work on this until he implements a settings UI where this setting will go. For now, if you'd like to contribute, please choose a different issue to work on.

@gnprice
Copy link
Member

gnprice commented Dec 16, 2024

As an example of where this is desired, we heard from a user today:

In our team we use English as a default language in communication and collaborative apps, tho our native language is not English. Right now in Flutter app I can't change system language, but in legacy app it's not a problem.
[…] my system language is not English

So they want Zulip in English although they have a different language chosen for the system overall.

@PrinceJohn279

This comment has been minimized.

@chrisbobbe

This comment has been minimized.

@AshutoshKhadse23
Copy link

Hello @chrisbobbe ,
Can you assign this to me?

issue.1139.mp4

@gnprice
Copy link
Member

gnprice commented Apr 2, 2025

Thanks. Instead of a popup submenu, let's put this as a screen underneath the main settings screen — that's a UX that will scale better when there are dozens of translations, which I expect there to be soon after the Zulip project as a whole completes our migration to Weblate and asks our community of translation contributors to translate this app there.

For a model of how that UI can work, see the language setting in the legacy app.

To make it available from the choose-account screen, we can add an option to go to the settings screen as one of the options in that menu.

@AshutoshKhadse23
Copy link

Hello @gnprice ,
Created PR based upon the updates required in UX

@PIG208 PIG208 linked a pull request May 16, 2025 that will close this issue
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 16, 2025
Since there is no Figma design for the settings page yet, the design is
kept simple while matching zulip-mobile: we show both selfname (in its
own locale) and name (in the ambient locale) of each available language
option, and leave out the search funtionality.

We don't allow unsetting the language once it is set, but that can
easily change.

Fixes: zulip#1139
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 16, 2025
Since there is no Figma design for the settings page yet, the design is
kept simple while matching zulip-mobile: we show both selfname (in its
own locale) and name (in the ambient locale) of each available language
option, and leave out the search funtionality.

We don't allow unsetting the language once it is set, but that can
easily change.

Fixes: zulip#1139
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue May 16, 2025
Since there is no Figma design for the settings page yet, the design is
kept simple while matching zulip-mobile: we show both selfname (in its
own locale) and name (in the ambient locale) of each available language
option, and leave out the search funtionality.

We don't allow unsetting the language once it is set, but that can
easily change.

Fixes: zulip#1139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-i18n Translation, localization, internationalization beta feedback Things beta users have specifically asked for
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants