Skip to content

iOS: Non-emoji text wrongly being rendered with "Noto Color Emoji" font #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Aug 31, 2023 · 2 comments · Fixed by #290
Closed

iOS: Non-emoji text wrongly being rendered with "Noto Color Emoji" font #289

chrisbobbe opened this issue Aug 31, 2023 · 2 comments · Fixed by #290
Assignees
@chrisbobbe
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work

Comments

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Aug 31, 2023 •
edited
Loading

Details: https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20text.20all.20weird/near/1633622
@chrisbobbe chrisbobbe self-assigned this Aug 31, 2023
@chrisbobbe
Copy link
Collaborator Author

As mentioned there, the culprit was 593d88a / #245.

@chrisbobbe
Copy link
Collaborator Author

Will send a PR shortly.

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Aug 31, 2023
@chrisbobbe
ui: For boring, non-emoji font, use one that iOS recognizes
f531599 
It's strange that iOS really doesn't seem to know what to do with
'sans-serif' here. Nor "SF Pro", "SF-Pro", nor any obvious variation
on that, even though it's supposedly the system font:
  https://developer.apple.com/fonts/

But a GitHub comment popped up a few hours ago (linked in the added
code), and that's the first thing I've found that seems to work, as
a clear pointer to the default system font. Shrug.

Later, we'll want to use Sorce Sans 3 for almost all the text in the
app. But we'll want to take more care with that than I have
bandwidth for right now (around it being a variable-weight font);
see discussion:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20text.20all.20weird/near/1633648

Fixes: zulip#289
@chrisbobbe chrisbobbe mentioned this issue Aug 31, 2023
Merged
@chrisbobbe chrisbobbe added the a-iOS Issues specific to iOS, or requiring iOS-specific work label Aug 31, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Aug 31, 2023
@chrisbobbe
ui: For boring, non-emoji font, use one that iOS recognizes
6508bbb 
It's strange that iOS really doesn't seem to know what to do with
'sans-serif' here. Nor "SF Pro", "SF-Pro", nor any obvious variation
on that, even though it's supposedly the system font:
  https://developer.apple.com/fonts/

But a GitHub comment popped up a few hours ago (linked in the added
code), and that's the first thing I've found that seems to work, as
a clear pointer to the default system font. Shrug.

Later, we'll want to use Source Sans 3 for almost all the text in the
app. But we'll want to take more care with that than I have
bandwidth for right now (around it being a variable-weight font);
see discussion:
  https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20text.20all.20weird/near/1633648

Fixes: zulip#289
@gnprice gnprice closed this as completed in b10296f Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work
Projects
Flutter app
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: For boring, non-emoji font, use one that iOS recognizes chrisbobbe/zulip-flutter
1 participant
@chrisbobbe