ui: For boring, non-emoji font, use one that iOS recognizes #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
added
the
a-iOS
gnprice
reviewed
Aug 31, 2023
lib/widgets/app.dart
Outdated
| fontFamilyFallback: [ | ||
| // …since apparently iOS doesn't support 'sans-serif', use this instead: | ||
| // https://github.com/flutter/flutter/issues/63507#issuecomment-1698504425 | ||
| if (Platform.isIOS) '.AppleSystemUIFont' else 'sans-serif', |
There was a problem hiding this comment.
This should be the Flutter "target platform", I think, rather than the actual current platform. Cf f669f16.
chrisbobbe
force-pushed
the
pr-ios-font-fix
branch
from
f531599 to
6508bbb
Compare
|
Thanks for the review! Revision pushed, and I'll go file that issue now. |
|
Thanks! Tweaked the link in the commit message to point to that issue #294 (which in turn points to the chat thread the commit message had linked to); merging. |
It's strange that iOS really doesn't seem to know what to do with 'sans-serif' here. Nor "SF Pro", "SF-Pro", nor any obvious variation on that, even though it's supposedly the system font: https://developer.apple.com/fonts/ But a GitHub comment popped up a few hours ago (linked in the added code), and that's the first thing I've found that seems to work, as a clear pointer to the default system font. Shrug. Later, we'll want to use Source Sans 3 for almost all the text in the app. But we'll want to take more care with that than I have bandwidth for right now (around it being a variable-weight font); see zulip#294. Fixes: zulip#289
gnprice
force-pushed
the
pr-ios-font-fix
branch
from
6508bbb to
b10296f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's strange that iOS really doesn't seem to know what to do with 'sans-serif' here. Nor "SF Pro", "SF-Pro", nor any obvious variation on that, even though it's supposedly the system font:
https://developer.apple.com/fonts/
But a GitHub comment popped up a few hours ago (linked in the added code), and that's the first thing I've found that seems to work, as a clear pointer to the default system font. Shrug.
Later, we'll want to use Sorce Sans 3 for almost all the text in the app. But we'll want to take more care with that than I have bandwidth for right now (around it being a variable-weight font); see discussion:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/flutter.3A.20text.20all.20weird/near/1633648
Fixes: #289