Skip to content

In user-agent, include platform, platform version, and app version #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Dec 28, 2023 · 1 comment · Fixed by #724
Closed

In user-agent, include platform, platform version, and app version #467

chrisbobbe opened this issue Dec 28, 2023 · 1 comment · Fixed by #724
Labels
a-api Implementing specific parts of the Zulip server API
Milestone
M3: Summer 2024

Comments

@chrisbobbe
Copy link
Collaborator

In the first pass for

, Greg suggests leaving out the platform, platform version, and app version. So I expect the user agent will look something like

ZulipMobile (actually ZulipFlutter)

instead of e.g.

ZulipMobile (Android 14) (actually ZulipFlutter/1.2.3)

. This issue is for filling in those missing things.
@chrisbobbe chrisbobbe added the a-api Implementing specific parts of the Zulip server API label Dec 28, 2023
@gnprice gnprice added this to the Beta 3 milestone Dec 29, 2023
@chrisbobbe chrisbobbe mentioned this issue Jan 3, 2024
Merged
@gnprice
Copy link
Member

gnprice commented Jan 3, 2024

In particular, after #471 there will be (as discussed at #471 (comment)) a sort of residual version of the following issue:

which is that the login emails will say "Device: Zulip on an unknown operating system" rather than the actual operating system.

Fixing this issue should fix that. When we have a PR for this issue, one thing we should manually test in it is that it does indeed fix that.

@rajveermalviya rajveermalviya mentioned this issue Jun 5, 2024
Merged
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 24, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
8458b72 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding, and since it now depends on them, move the function
to the ZulipBinding class — making it explicit to the caller that
it depends on ZulipBinding being initialised.

In addition to that, support fetching macOS, Windows and Linux
device information, so that user-agents for them can be generated.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 24, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
a68aaca 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding, and since it now depends on them, move the function
to the ZulipBinding class — making it explicit to the caller that
it depends on ZulipBinding being initialised.

In addition to that, support fetching macOS, Windows and Linux
device information, so that user-agents for them can be generated.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 26, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
a9cf8d3 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding, and since it now depends on them, move the function
to the ZulipBinding class — making it explicit to the caller that
it depends on ZulipBinding being initialised.

In addition to that, support fetching macOS, Windows and Linux
device information, so that user-agents for them can be generated.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 30, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
6e08702 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding, and since it now depends on them, move the function
to the ZulipBinding class — making it explicit to the caller that
it depends on ZulipBinding being initialised.

In addition to that, support fetching macOS, Windows and Linux
device information, so that user-agents for them can be generated.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jun 30, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
798aec6 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 1, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
7ba0e82 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 7, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
6ac9ab7 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 7, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
abbcfaf 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 9, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
7023109 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 11, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
66df466 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding.

Fixes: zulip#467
rajveermalviya added a commit to rajveermalviya/zulip-flutter that referenced this issue Jul 13, 2024
@rajveermalviya
api: Embed platform and app info in user-agent
7f2160c 
Generate the user-agent using `deviceInfo` and `packageInfo` from
ZulipBinding.

Fixes: zulip#467
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Flutter app
Status: Done
Milestone
M3: Summer 2024
Development

Successfully merging a pull request may close this issue.

api: Embed platform and app info in user-agent rajveermalviya/zulip-flutter
2 participants
@gnprice @chrisbobbe