Skip to content

Run Android build in CI #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Jun 28, 2024 · 0 comments · Fixed by #796
Closed

Run Android build in CI #772

gnprice opened this issue Jun 28, 2024 · 0 comments · Fixed by #796
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-tests a-tools Our own development tooling, scripts, and infrastructure

Comments

@gnprice
Copy link
Member

gnprice commented Jun 28, 2024

This would help us more quickly catch issues where the build gets broken, like:

It'd also be helpful for when we're making changes to our Android-side code (including our Kotlin source code and our Android build setup).

Once we have this in our own CI, we should also (and I'll file a separate issue for this) see about putting it into Flutter's customer tests (like we've already done with flutter analyze and flutter test, as #239). That way, an issue like #771 would be caught at an earlier stage — the PR that made that change in the Flutter repo would have already seen a test failure. At that point, running it in our own CI on Flutter upgrades should be a bit redundant — but it'll still be valuable for upgrading other dependencies, and for our own changes.

@gnprice gnprice added a-Android Issues specific to Android, or requiring Android-specific work a-tools Our own development tooling, scripts, and infrastructure a-tests labels Jun 28, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Android Issues specific to Android, or requiring Android-specific work a-tests a-tools Our own development tooling, scripts, and infrastructure
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant