-
Notifications
You must be signed in to change notification settings - Fork 309
Do Android build in CI #796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a185d56
to
a618e33
Compare
Thanks, LGTM! I'll hold off merging until @rajveermalviya has a chance to look. |
The other day I remarked: There's also an Android linter, but it has a different job. I'll send a separate PR for running that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @gnprice, LGTM!
I tried this with macOS M1 runner (macos-latest
), but surprisingly it didn't make much difference: https://github.com/rajveermalviya/zulip-flutter/actions/runs/9852479999
Thanks for trying that. Yeah, it's a shame that this adds so much to the time CI requires — about 4 minutes. It'd be good to find a way to reduce that, but I'm not sure there will be a good way; I think building an Android app is just slow compared to what we do in |
And give it the necessary prerequisites in CI. By default the build worker supplies JDK 11, apparently, and that's too old.
In particular this applies to the new `tools/check android`. A StackOverflow question that had a couple of helpful answers: https://stackoverflow.com/questions/34562200/how-do-i-make-the-kotlin-compiler-treat-warnings-as-errors
Fixes #772.
(Started as a draft PR, because I wasn't sure if more setup was needed in ci.yml in order for this build to work. Indeed some was.)