deps: Upgrade Flutter to 3.33.0-1.0.pre-1086 #1738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sm-sayedi
added
the
integration review
sm-sayedi
force-pushed
the
flutter-upgrade-25/07/24
branch
2 times, most recently
from
cf27c72 to
ae988d7
Compare
gnprice
force-pushed
the
flutter-upgrade-25/07/24
branch
from
ae988d7 to
fa35ed4
Compare
|
Thanks! Looks good; merging. |
And update Flutter's supporting libraries to match.
gnprice
force-pushed
the
flutter-upgrade-25/07/24
branch
from
fa35ed4 to
55d055f
Compare
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Jul 25, 2025
This reverts commit 55d055f (zulip#1738). That change was described as upgrading Flutter and its supporting libraries, but it looks like it accidentally included other upgrades, something like `flutter pub upgrade`. It also didn't include the CocoaPods updates for those upgrades; see zulip#1746. So revert that change, to get back to a well-understood state. Then we can retry the upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update Flutter's supporting libraries to match.
With this upgrade, we can now use the route transition duration in tests to wait the minimum amount of time needed for the route animation to complete.
Related upstream PR: flutter/flutter#171109