Skip to content

Conversation

rajveermalviya
Copy link
Member

Looks like #1738 also upgraded some pub dependencies, so CocoaPods dependencies are now out-of-date, resulting in the following error when building on iOS:

…
Error: CocoaPods's specs repository is too out-of-date to satisfy dependencies.
To update the CocoaPods specs, run:
  pod repo update



Error running pod install
Error launching application on iPhone 16 Pro.

This PR fixes that by updating CocoaPods dependencies.

@rajveermalviya rajveermalviya added the integration review Added by maintainers when PR may be ready for integration label Jul 24, 2025
@gnprice
Copy link
Member

gnprice commented Jul 25, 2025

Hmm I see — #1738's description said it was upgrading Flutter (and supporting libraries), but in fact it upgraded a bunch of third-party libraries as well. It looks a lot like the output of flutter pub upgrade. Thanks for catching that!

I'll start by reverting that commit; then we can do the upgrade again but in individual pieces.

If tools/upgrade flutter-local produced that commit in #1738 (/cc @sm-sayedi), then there's probably also something we can do in the script to make it more robust against whatever situation led to that.

gnprice added a commit to gnprice/zulip-flutter that referenced this pull request Jul 25, 2025
This reverts commit 55d055f (zulip#1738).

That change was described as upgrading Flutter and its supporting
libraries, but it looks like it accidentally included other upgrades,
something like `flutter pub upgrade`.  It also didn't include the
CocoaPods updates for those upgrades; see zulip#1746.

So revert that change, to get back to a well-understood state.
Then we can retry the upgrade.
@gnprice
Copy link
Member

gnprice commented Jul 25, 2025

Did that revert as #1749. Thanks again for spotting this.

@gnprice gnprice closed this Jul 25, 2025
@sm-sayedi
Copy link
Collaborator

Sorry that it caused the inconvenience. It was not tools/upgrade flutter-local that made changes to the other package. When I first opened that PR and CI failed, one of the messages there was that the analyzer needs to be updated by using flutter pub upgrade. So I quickly amended that commit and pushed to see if it fixes CI which it didn't and turned out that #1739 was the fix. I wanted to leave a comment in #1738 saying that l will push again (and not include additional package changes) when that fix is merged, but I totally forgot it.

@gnprice
Copy link
Member

gnprice commented Jul 25, 2025

Got it, thanks.

The one step I'd ask that you do differently next time, then, is to do the flutter pub upgrade as a separate commit. (And if you're not sure whether it should be squashed into the original commit, mention that on the PR — it's easy to squash later.)

That way it's clear where the changes came from, which makes it easier to review them quickly without missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants