-
Notifications
You must be signed in to change notification settings - Fork 3k
STM32: RESET GPIO during init is configurable #14032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@jeromecoutant, thank you for your changes. |
targets/targets.json
Outdated
@@ -3200,6 +3204,9 @@ | |||
"macro_name": "CLOCK_SOURCE" | |||
} | |||
}, | |||
"overrides": { | |||
"gpio_reset_at_init": 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"gpio_reset_at_init": 1 | |
"gpio_reset_at_init": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugueskamba
Done
targets/targets.json
Outdated
}, | ||
"gpio_reset_at_init": { | ||
"help": "if value set, all GPIO are reset during init", | ||
"value": 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"value": 0 | |
"value": false |
9f0293d
to
92dcf8e
Compare
@jeromecoutant please rebase to resolve Travis error (latest master). This type of config would make sense to be for all targets (not part of this PR), just thinking we shall upstream it one day. To recap, it was fixed to reset all gpio pins during startup. This however has implications so it should be configurable (13826 PR was affected unfortunately). Correct? |
Default value is disabled
92dcf8e
to
d689e90
Compare
Done
Yes |
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@jeromecoutant can you check ethernet failures if they are related to this PR? |
I don't see any failed tests in the log... NB: see https://forums.mbed.com/t/cant-debug-with-nucleo-stm32f411re-stlink-error-22/11550/10 |
I restarted tests to confirm if its related, if fail again, I'll check the failures in detail. |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Let's merge ? |
Summary of changes
Since #13777, GPIO are all reset during init before application starts.
Now this reset is done only if, in order to optimize power, application is configured it in mbed_app.json
@facchinm
@LMESTM
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers