Skip to content

STM32: RESET GPIO during init is configurable #14032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

STM32: RESET GPIO during init is configurable #14032

merged 1 commit into from
Jan 15, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

Since #13777, GPIO are all reset during init before application starts.

Now this reset is done only if, in order to optimize power, application is configured it in mbed_app.json

    "overrides": {
        "target.gpio_reset_at_init": 1
    },

@facchinm
@LMESTM

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant jeromecoutant mentioned this pull request Dec 11, 2020
Merged
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Dec 11, 2020
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from a team December 11, 2020 16:30
hugueskamba
hugueskamba reviewed Dec 31, 2020
View reviewed changes
targets/targets.json Outdated
@@ -3200,6 +3204,9 @@
"macro_name": "CLOCK_SOURCE"
}
},
"overrides": {
"gpio_reset_at_init": 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"gpio_reset_at_init": 1
"gpio_reset_at_init": true

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugueskamba
Done

targets/targets.json Outdated
},
"gpio_reset_at_init": {
"help": "if value set, all GPIO are reset during init",
"value": 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"value": 0
"value": false

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

@jeromecoutant please rebase to resolve Travis error (latest master).

This type of config would make sense to be for all targets (not part of this PR), just thinking we shall upstream it one day.

To recap, it was fixed to reset all gpio pins during startup. This however has implications so it should be configurable (13826 PR was affected unfortunately). Correct?

@jeromecoutant
Copy link
Collaborator Author

please rebase to resolve Travis error (latest master).

Done

To recap, it was fixed to reset all gpio pins during startup. This however has implications so it should be configurable (13826 PR was affected unfortunately). Correct?

Yes

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

CI started

@0xc0170 0xc0170 requested a review from hugueskamba January 5, 2021 13:19
@mbed-ci
Copy link

mbed-ci commented Jan 5, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Jan 5, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 5, 2021

@jeromecoutant can you check ethernet failures if they are related to this PR?

@jeromecoutant
Copy link
Collaborator Author

@jeromecoutant can you check ethernet failures if they are related to this PR?

I don't see any failed tests in the log...

NB: see https://forums.mbed.com/t/cant-debug-with-nucleo-stm32f411re-stlink-error-22/11550/10
This PR seems important

@jeromecoutant jeromecoutant mentioned this pull request Jan 11, 2021
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

I restarted tests to confirm if its related, if fail again, I'll check the failures in detail.

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@jeromecoutant
Copy link
Collaborator Author

Let's merge ?

@jeromecoutant jeromecoutant mentioned this pull request Jan 14, 2021
Closed
@Copper-Bot Copper-Bot mentioned this pull request Jan 15, 2021
Closed
@0xc0170 0xc0170 merged commit eff0d4c into ARMmbed:master Jan 15, 2021
@mergify mergify bot removed the ready for merge label Jan 15, 2021
@jeromecoutant jeromecoutant deleted the PR_RESET_GPIO branch January 15, 2021 15:51
This was referenced Jan 15, 2021
Closed
Closed
@jeromecoutant jeromecoutant mentioned this pull request Jan 20, 2021
Closed
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
@ladislas ladislas mentioned this pull request Feb 4, 2021
Merged
@jeromecoutant jeromecoutant mentioned this pull request Feb 24, 2021
Closed
@lukgni lukgni mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@hugueskamba hugueskamba Awaiting requested review from hugueskamba

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jeromecoutant @ciarmcom @0xc0170 @mbed-ci @hugueskamba @mbedmain