Enhance targets.json with components #9721

theamirocohen · 2019-02-14T15:19:30Z

Description

The enhancement is further specified here.
Due to the enhancement some boards failed the general block device tests for flashiap component,
The fails were due to boards containing inconsistent sector sizes.
The tests were modified but should be improved to address the problem.

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-storage

0xc0170 · 2019-02-15T09:23:59Z

targets/targets.json

-            "MBEDTLS_PSA_CRYPTO_C"
-        ],
+        "components_add": ["SD", "FLASHIAP"],
+        "macros_add": ["MBEDTLS_PSA_CRYPTO_C"],


Why changing styling for this line? should be separate commit if needed

0xc0170 · 2019-02-15T09:24:23Z

features/storage/TESTS/blockdevice/general_block_device/main.cpp

@@ -195,6 +195,11 @@ void basic_erase_program_read_test(BlockDevice *block_device, bd_size_t block_si
    // Find a random block
    bd_addr_t block = (rand() * block_size) % (block_device->size());

+    // Flashiap boards with inconsistent sector size will to align with random start addresses


How is this related to json update? Separate commit?

0xc0170

The tests were modified but should be improved to address the problem.

Where is this issue tracked?

0xc0170 · 2019-02-18T10:21:04Z

CI started

This PR is waiting for final approval from @ARMmbed/mbed-os-storage team

0xc0170 · 2019-02-18T10:22:16Z

What's the release target ? Is this fix for 5.11.5?

theamirocohen · 2019-02-18T10:30:05Z

The tests were modified but should be improved to address the problem.

Where is this issue tracked?

https://jira.arm.com/browse/IOTSTOR-789 & https://jira.arm.com/browse/IOTSTOR-790

theamirocohen · 2019-02-18T10:44:46Z

What's the release target ? Is this fix for 5.11.5?

It can be for 5.12 (because we're adding targets)

0xc0170 · 2019-02-18T11:38:25Z

It's adding support for components to targets, set for 5.11.5

mbed-ci · 2019-02-18T11:52:00Z

Test run: FAILED

Summary: 3 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-ARM
jenkins-ci/mbed-os-ci_build-IAR
jenkins-ci/mbed-os-ci_build-GCC_ARM

0xc0170 · 2019-02-18T12:17:13Z

Please review build failures

0xc0170 · 2019-02-18T15:49:45Z

CI restarted

jeromecoutant · 2019-02-18T16:27:39Z

targets/targets.json

@@ -2560,7 +2562,7 @@
        }
    },
    "DISCO_F413ZH": {
-        "components_add": ["QSPIF"],
+        "components_add": ["QSPIF", "SD", "FLASHIAP"],


I don't think adding SD is correct
(on DISCO_F413ZH, SD connector is using SDIO not SPI)

Hi @jeromecoutant,
So how can I approach this? should I delete it?

jeromecoutant · 2019-02-18T16:28:14Z

targets/targets.json

@@ -3791,7 +3795,7 @@
            "STM32F746NG",
            "STM_EMAC"
        ],
-        "components_add": ["QSPIF"],
+        "components_add": ["QSPIF", "SD", "FLASHIAP"],


SD seems not correct ?

Hi @jeromecoutant,
How do you know it is not correct?

Because board doesn't have any embedded SD connector over SPI

mbed-ci · 2019-02-18T17:39:15Z

Test run: FAILED

Summary: 1 of 12 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_greentea-test

0xc0170 · 2019-02-20T13:27:48Z

@theamirocohen Can you review test failures?

cmonr · 2019-02-20T17:10:41Z

@theamirocohen All greentea failures are around NUCLEO_F746ZG. Please review.

cmonr · 2019-02-25T23:07:31Z

CI started

mbed-ci · 2019-02-26T03:25:38Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

cmonr · 2019-02-26T03:35:06Z

@ARMmbed/mbed-os-storage Anyone care to give the final OK?

Adding storage components to boards

Due to targets enhancement some boards failed the general block device tests for flashiap component, The fails were due to boards containing inconsistent sector sizes. The tests were modified but should be improved to address the problem. Rand() function issues were fixed.

0xc0170 · 2019-02-26T15:20:04Z

This fix needed for IAR8, changed destination branch.

Update: we will take this via rollup PR to the feature branch, will update here once done

deepikabhavnani · 2019-02-26T15:30:12Z

Roll up PR is created for this change to perform CI testing. #9858

cmonr · 2019-02-26T19:22:47Z

Leaving a note. This should automatically close once #9808 is merged.

cmonr · 2019-02-26T21:45:38Z

Closing since rollup PR, and feature-iar8 are now in master.

PR was not automatically closed because PR's commits were cherrypicked instead of merged (b8fed58 c07ba7c)

cmonr requested a review from a team February 14, 2019 15:24

cmonr added the needs: review label Feb 14, 2019

cmonr approved these changes Feb 15, 2019

View reviewed changes

0xc0170 requested changes Feb 15, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Feb 15, 2019

theamirocohen force-pushed the update_target_comp branch from c9b2a38 to 96edb8a Compare February 17, 2019 08:16

0xc0170 approved these changes Feb 18, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Feb 18, 2019

0xc0170 added the release-version: 5.11.5 label Feb 18, 2019

0xc0170 added needs: work and removed needs: CI labels Feb 18, 2019

jeromecoutant reviewed Feb 18, 2019

View reviewed changes

cmonr removed the release-version: 5.11.5 label Feb 21, 2019

cmonr added the needs: review label Feb 26, 2019

cmonr added risk: G release-version: 5.12.0-rc1 and removed needs: work labels Feb 26, 2019

Amir Cohen added 2 commits February 26, 2019 09:26

Enhance targets.json with components

8a3cc4c

Adding storage components to boards

theamirocohen force-pushed the update_target_comp branch from a1f8219 to dd1c33a Compare February 26, 2019 07:34

dannybenor approved these changes Feb 26, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Feb 26, 2019

theamirocohen mentioned this pull request Feb 26, 2019

rand() and srand() are made sparse to not have same block. #9820

Closed

deepikabhavnani mentioned this pull request Feb 26, 2019

IAR 8 feature branch merge #9808

Merged

0xc0170 changed the base branch from master to feature-iar8 February 26, 2019 15:19

deepikabhavnani mentioned this pull request Feb 26, 2019

Roll up PR for feature-iar8 #9858

Merged

cmonr added do not merge rollup PR and removed release-version: 5.12.0-rc1 risk: G labels Feb 26, 2019

cmonr closed this Feb 26, 2019

cmonr removed do not merge needs: CI rollup PR labels Feb 26, 2019

Enhance targets.json with components #9721

Enhance targets.json with components #9721

Uh oh!

Conversation

theamirocohen commented Feb 14, 2019

Description

Pull request type

Reviewers

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 18, 2019

Uh oh!

0xc0170 commented Feb 18, 2019

Uh oh!

theamirocohen commented Feb 18, 2019

Uh oh!

theamirocohen commented Feb 18, 2019

Uh oh!

0xc0170 commented Feb 18, 2019

Uh oh!

mbed-ci commented Feb 18, 2019

Uh oh!

0xc0170 commented Feb 18, 2019

Uh oh!

0xc0170 commented Feb 18, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mbed-ci commented Feb 18, 2019

Uh oh!

0xc0170 commented Feb 20, 2019

Uh oh!

cmonr commented Feb 20, 2019

Uh oh!

cmonr commented Feb 25, 2019

Uh oh!

mbed-ci commented Feb 26, 2019

Uh oh!

cmonr commented Feb 26, 2019

Uh oh!

0xc0170 commented Feb 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepikabhavnani commented Feb 26, 2019

Uh oh!

cmonr commented Feb 26, 2019

Uh oh!

cmonr commented Feb 26, 2019

Uh oh!

Uh oh!

0xc0170 commented Feb 26, 2019 •

edited

Loading