-
Notifications
You must be signed in to change notification settings - Fork 3k
Enhance targets.json with components #9721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance targets.json with components #9721
Conversation
targets/targets.json
Outdated
"MBEDTLS_PSA_CRYPTO_C" | ||
], | ||
"components_add": ["SD", "FLASHIAP"], | ||
"macros_add": ["MBEDTLS_PSA_CRYPTO_C"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why changing styling for this line? should be separate commit if needed
@@ -195,6 +195,11 @@ void basic_erase_program_read_test(BlockDevice *block_device, bd_size_t block_si | |||
// Find a random block | |||
bd_addr_t block = (rand() * block_size) % (block_device->size()); | |||
|
|||
// Flashiap boards with inconsistent sector size will to align with random start addresses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this related to json update? Separate commit?
c9b2a38
to
96edb8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests were modified but should be improved to address the problem.
Where is this issue tracked?
CI started This PR is waiting for final approval from @ARMmbed/mbed-os-storage team |
What's the release target ? Is this fix for 5.11.5? |
https://jira.arm.com/browse/IOTSTOR-789 & https://jira.arm.com/browse/IOTSTOR-790 |
It can be for 5.12 (because we're adding targets) |
It's adding support for components to targets, set for 5.11.5 |
Test run: FAILEDSummary: 3 of 8 test jobs failed Failed test jobs:
|
Please review build failures |
CI restarted |
targets/targets.json
Outdated
@@ -2560,7 +2562,7 @@ | |||
} | |||
}, | |||
"DISCO_F413ZH": { | |||
"components_add": ["QSPIF"], | |||
"components_add": ["QSPIF", "SD", "FLASHIAP"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think adding SD is correct
(on DISCO_F413ZH, SD connector is using SDIO not SPI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeromecoutant,
So how can I approach this? should I delete it?
targets/targets.json
Outdated
@@ -3791,7 +3795,7 @@ | |||
"STM32F746NG", | |||
"STM_EMAC" | |||
], | |||
"components_add": ["QSPIF"], | |||
"components_add": ["QSPIF", "SD", "FLASHIAP"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SD seems not correct ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeromecoutant,
How do you know it is not correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because board doesn't have any embedded SD connector over SPI
Test run: FAILEDSummary: 1 of 12 test jobs failed Failed test jobs:
|
@theamirocohen Can you review test failures? |
@theamirocohen All greentea failures are around NUCLEO_F746ZG. Please review. |
CI started |
Test run: SUCCESSSummary: 12 of 12 test jobs passed |
@ARMmbed/mbed-os-storage Anyone care to give the final OK? |
Adding storage components to boards
Due to targets enhancement some boards failed the general block device tests for flashiap component, The fails were due to boards containing inconsistent sector sizes. The tests were modified but should be improved to address the problem. Rand() function issues were fixed.
a1f8219
to
dd1c33a
Compare
This fix needed for IAR8, changed destination branch. Update: we will take this via rollup PR to the feature branch, will update here once done |
Roll up PR is created for this change to perform CI testing. #9858 |
Leaving a note. This should automatically close once #9808 is merged. |
Description
The enhancement is further specified here.
Due to the enhancement some boards failed the general block device tests for flashiap component,
The fails were due to boards containing inconsistent sector sizes.
The tests were modified but should be improved to address the problem.
Pull request type
Reviewers
@ARMmbed/mbed-os-storage