Skip to content

Roll up PR for feature-iar8 #9858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 26, 2019
Merged

Roll up PR for feature-iar8 #9858

merged 7 commits into from
Feb 26, 2019

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Feb 26, 2019 •
edited
Loading

Description

This is roll-up PR to pick up IAR 8 specific changes.

  1. Revert roll_up_iar8
  2. Add IAR8 binaries for USI_WM_BN_BM_22 and EMW3166 based chips #9847
  3. Enhance targets.json with components #9721
  4. Merge SPIF & QSPIF components test to general block device tests #9855

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

CC @0xc0170

Release Notes

Deepika and others added 4 commits February 26, 2019 09:21
Revert "rand() by default does increment of 1, randomizing more"
d2e1196 
This reverts commit f7a6d25.
Enhance targets.json with components
c07ba7c 
Adding storage components to boards
Modifing general block device tests doe to targets enhancement
b8fed58 
Due to targets enhancement some boards failed the general block device tests for flashiap component,
The fails were due to boards containing inconsistent sector sizes.
The tests were modified but should be improved to address the problem.
Rand() function issues were fixed.
Add IAR8 binaries for USI_WM_BN_BM_22 and EMW3166 based chips
6d04fa7
This was referenced Feb 26, 2019
Closed
Closed
@adbridge
Copy link
Contributor

CI started

@deepikabhavnani deepikabhavnani mentioned this pull request Feb 26, 2019
Merged
@mbed-ci
Copy link

mbed-ci commented Feb 26, 2019

Test run: FAILED

Summary: 1 of 3 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR8

@cmonr
Copy link
Contributor

cmonr commented Feb 26, 2019

Making a note that the first commit was this revert: f7a6d25

@cmonr
Copy link
Contributor

cmonr commented Feb 26, 2019 •
edited
Loading

Info: CI was aborted since an additional change is landing shortly.

Merge SPIF & QSPIF components test to general block device tests
5c7f6cb 
The SPIF and QPIF components tests are fully merged into general block device tests and were deleted
@deepikabhavnani
Copy link
Author

  1. Added Merge SPIF & QSPIF components test to general block device tests #9855
  2. Enable Cypress for Mbed 5 release
  3. Remove IAR from required toolchains list

@adbridge
Copy link
Contributor

CI restarted

@deepikabhavnani deepikabhavnani mentioned this pull request Feb 26, 2019
Closed
@mbed-ci
Copy link

mbed-ci commented Feb 26, 2019

Test run: SUCCESS

Summary: 6 of 6 test jobs passed
Build number : 2
Build artifacts

@deepikabhavnani
Copy link
Author

Ready for merge?

@cmonr cmonr merged commit 74d8315 into ARMmbed:feature-iar8 Feb 26, 2019
@cmonr cmonr removed the needs: CI label Feb 26, 2019
@deepikabhavnani deepikabhavnani deleted the roll_up_iar8 branch February 26, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: feature branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deepikabhavnani @adbridge @mbed-ci @cmonr @0xc0170