IAR 8 feature branch merge #9808

deepikabhavnani · 2019-02-22T06:07:02Z

Description

IAR 8.x feature branch merge.

@ARMmbed/mbed-os-test-team - Please switch CI on master branch to IAR 8.32 after 5.11.5 release candidate is ready.

@ARMmbed/mbed-os-maintainers - If PR #9807 is merged before starting CI for this, then it should show up here. Else can update #9807 to be against master, if this is merged.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@SenRamakri

Release Notes

Updating the IAR toolchain version to IAR 8.32.

ciarmcom · 2019-02-22T08:00:29Z

@deepikabhavnani, thank you for your changes.
@SenRamakri @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-tools please review.

Two new block properties available in linker configuration files: "expanding size" and "minimum size" for IAR 8.11.2 and above Sample: define block HEAP with expanding size, minimum size = 16K, alignment = 8 {}; This block will expand to consume all remaining available space in the range where it is placed. If several such blocks end up in the same range, they will share the remaining space. Cannot place a block with expanding size inside another block with expanding size, inside a block with maximum size, or inside an overlay.

RAM define/section if splited, IAR exanpding size considers just one section while heap creation which results in smaller chunk for heap. This commit is to unify the RAM section.

Few targets have libraries compatible to IAR 7.x, which fail with IAR 8.x, IAR support for them is removed till updated library is added. CI failure seen if IAR is not added as supported target, trying with release_version as empty string List of targets affected: 1. UBLOX_EVK_ODIN_W2 2. MTB_UBLOX_ODIN_W2 3. MBED_CONNECT_ODIN 4. MTB_MXCHIP_EMW3166 5. MTB_ADV_WISE_1530 6. MTB_USI_WM_BN_BM_22 7. REALTEK_RTL8195AM

Reference template file is used from IAR8.32 installation available at path "Embedded Workbench 8.2\arm\config\template\ConvertToIAR\template_project.ewp" Also added trustzone configs in iar_definitions.json

Two new block properties available in linker configuration files: "expanding size" and "minimum size" for IAR 8.11.2 and above Sample: define block HEAP with expanding size, minimum size = 16K, alignment = 8 {}; This block will expand to consume all remaining available space in the range where it is placed. If several such blocks end up in the same range, they will share the remaining space. Cannot place a block with expanding size inside another block with expanding size, inside a block with maximum size, or inside an overlay.

Reverting this feature till IAR 8.x is stable and supported in Mbed OS for few releases 1. Revert "Add Dynamic heap support to IAR" This reverts commit 8ee29bb. 2. Revert "Splited RAM section not compatible with dynamic HEAP." This reverts commit a645bb2. 3. Revert "Add Dynamic heap support to IAR" This reverts commit 891e1f2.

timurh01 · 2019-02-22T10:05:00Z

There are still targets that are failing IAR8 nightly build and are passing on IAR7 nightly build.

CY8CKIT_062_4343W
CY8CKIT_062_BLE
CY8CKIT_062_WIFI_BT
CY8CPROTO_062_4343W
CYW943012P6EVB_01
FUTURE_SEQUANA
FUTURE_SEQUANA_M0
FUTURE_SEQUANA_PSA
MTB_ADV_WISE_1530
MTB_MXCHIP_EMW3166
MTB_USI_WM_BN_BM_22
REALTEK_RTL8195AM

deepikabhavnani · 2019-02-22T12:21:22Z

@timurh01 - all the targets in list except sequana are expected to fail, since they have non-compatible libraries and fixes for them will come directly on master branch. I will check Sequana failures

timurh01 · 2019-02-22T13:18:24Z

@deepikabhavnani Have plans changed at somepoint? Because test team has been under the impression that every target should be green before merge.

deepikabhavnani · 2019-02-22T14:20:45Z

Have plans changed at somepoint? Because test team has been under the impression that every target should be green before merge.

No, every target should be green for merging PR in master.
In case of nightly build the errors state "Target does not support IAR toolchain", i.e because nightly for feature-iar8 has explicitly targets selected and not based on what is supported.

bridadan

Looks ok, besides the disabled targets (though looks like you're addressing those)

tools/export/iar/ewp.tmpl

Random number generation in case of IAR 8, requires TLS support. Thread local storage is not part of Mbed OS, test is updated to have random numbers sparse, but in future random number creation should be moved to main thread, or use some other logic for randomization instead of rand() call.

0xc0170 · 2019-02-25T08:48:20Z

CY8CKIT_062_4343W

CY8CKIT_062_BLE
CY8CKIT_062_WIFI_BT
CY8CPROTO_062_4343W
CYW943012P6EVB_01
FUTURE_SEQUANA
FUTURE_SEQUANA_M0
FUTURE_SEQUANA_PSA
MTB_ADV_WISE_1530
MTB_MXCHIP_EMW3166
MTB_USI_WM_BN_BM_22
REALTEK_RTL8195AM

@deepikabhavnani Where is this being tracked?

As the branch was updated and rebased, restarting CI

mbed-ci · 2019-02-25T10:11:30Z

Test run: FAILED

Summary: 1 of 8 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

jenkins-ci/mbed-os-ci_build-IAR

0xc0170 · 2019-02-26T15:13:59Z

Rebase on master after Enhance targets.json with components #9721 is merged to master

Can we include 9721 here? That would be the easiest approach at this moment. it was approved, already tested once. And would fix the issue with IAR8.

This reverts commit f7a6d25.

Adding storage components to boards

Due to targets enhancement some boards failed the general block device tests for flashiap component, The fails were due to boards containing inconsistent sector sizes. The tests were modified but should be improved to address the problem. Rand() function issues were fixed.

adbridge · 2019-02-26T16:25:57Z

Now aborted CI

The SPIF and QPIF components tests are fully merged into general block device tests and were deleted

This reverts commit 334b2d6. This commit is not required any more as changes for this are already part of master branch

Roll up PR for feature-iar8

Revert "Update params in calls to LDREXW/STREXW to uint32_t"

cmonr · 2019-02-26T19:35:12Z

CI started

mbed-ci · 2019-02-26T21:13:27Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

0xc0170 · 2019-02-26T21:22:02Z

targets/targets.json

        "post_binary_hook": {
            "function": "RTL8195ACode.binary_hook",
            "toolchains": ["ARM_STD", "GCC_ARM", "IAR"]
        },
-        "release_versions": ["5"],
+        "release_versions": [],


this should still have version 5 ?

If it does, I think it should come in via a followup PR, considering how much this PR is blocking.

just final check :) LGTM

0xc0170

Just one line - might need an update

0xc0170 · 2019-02-26T21:25:28Z

@SenRamakri Please review, this PR needs approvals!

tools/toolchains/iar.py

ciarmcom requested review from SenRamakri and a team February 22, 2019 08:00

ciarmcom added the needs: review label Feb 22, 2019

0xc0170 added the release-version: 5.12.0-rc1 label Feb 22, 2019

aqib-ublox and others added 10 commits February 22, 2019 09:25

adding updated binary for IAR v8.32

84f52a8

Update params in calls to LDREXW/STREXW to uint32_t

334b2d6

Splited RAM section not compatible with dynamic HEAP.

ea3fa02

RAM define/section if splited, IAR exanpding size considers just one section while heap creation which results in smaller chunk for heap. This commit is to unify the RAM section.

Update IAR project template as per IAR 8.32

5501947

Reference template file is used from IAR8.32 installation available at path "Embedded Workbench 8.2\arm\config\template\ConvertToIAR\template_project.ewp" Also added trustzone configs in iar_definitions.json

Target_PSOC6 - Remove IAR supported from targets failing IAR 8.32 build

d67536d

Enable ODIN boards

270827b

bridadan reviewed Feb 22, 2019

View reviewed changes

tools/export/iar/ewp.tmpl Show resolved Hide resolved

bridadan approved these changes Feb 22, 2019

View reviewed changes

NirSonnenschein force-pushed the feature-iar8 branch from 66e93fd to f7a6d25 Compare February 24, 2019 16:42

0xc0170 requested a review from bulislaw February 25, 2019 08:47

0xc0170 added risk: A needs: CI and removed needs: review labels Feb 25, 2019

Deepika and others added 4 commits February 26, 2019 09:21

Revert "rand() by default does increment of 1, randomizing more"

d2e1196

This reverts commit f7a6d25.

Enhance targets.json with components

c07ba7c

Adding storage components to boards

Add IAR8 binaries for USI_WM_BN_BM_22 and EMW3166 based chips

6d04fa7

Deepika and others added 5 commits February 26, 2019 10:26

Remove IAR from required toolchains list

1ad2343

Enable Cypress for Mbed 5 release

915424a

Merge SPIF & QSPIF components test to general block device tests

5c7f6cb

The SPIF and QPIF components tests are fully merged into general block device tests and were deleted

Revert "Update params in calls to LDREXW/STREXW to uint32_t"

e0b4b51

This reverts commit 334b2d6. This commit is not required any more as changes for this are already part of master branch

Merge pull request #9858 from deepikabhavnani/roll_up_iar8

74d8315

Roll up PR for feature-iar8

cmonr mentioned this pull request Feb 26, 2019

Enhance targets.json with components #9721

Closed

Merge pull request #9863 from deepikabhavnani/old_commit_revert

e64286b

Revert "Update params in calls to LDREXW/STREXW to uint32_t"

0xc0170 reviewed Feb 26, 2019

View reviewed changes

cmonr added needs: CI and removed needs: preceding PR labels Feb 26, 2019

cmonr removed the needs: review label Feb 26, 2019

0xc0170 approved these changes Feb 26, 2019

View reviewed changes

cmonr reviewed Feb 26, 2019

View reviewed changes

tools/toolchains/iar.py Show resolved Hide resolved

cmonr approved these changes Feb 26, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: CI labels Feb 26, 2019

cmonr merged commit d29312e into master Feb 26, 2019

cmonr removed the ready for merge label Feb 26, 2019

DanielDmlee mentioned this pull request Apr 29, 2019

Add target RTL8710AF #7965

Closed

adbridge deleted the feature-iar8 branch August 20, 2019 10:50

IAR 8 feature branch merge #9808

IAR 8 feature branch merge #9808

Uh oh!

Conversation

deepikabhavnani commented Feb 22, 2019

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Feb 22, 2019

Uh oh!

timurh01 commented Feb 22, 2019

Uh oh!

deepikabhavnani commented Feb 22, 2019

Uh oh!

timurh01 commented Feb 22, 2019

Uh oh!

deepikabhavnani commented Feb 22, 2019

Uh oh!

bridadan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

0xc0170 commented Feb 25, 2019

Uh oh!

mbed-ci commented Feb 25, 2019

Test run: FAILED

Uh oh!

0xc0170 commented Feb 26, 2019

Uh oh!

adbridge commented Feb 26, 2019

Uh oh!

cmonr commented Feb 26, 2019

Uh oh!

mbed-ci commented Feb 26, 2019

Test run: SUCCESS

Uh oh!

0xc0170 Feb 26, 2019

Choose a reason for hiding this comment

Uh oh!

cmonr Feb 26, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 Feb 26, 2019

Choose a reason for hiding this comment

Uh oh!

0xc0170 left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 26, 2019

Uh oh!

Uh oh!

Uh oh!

bridadan left a comment •

edited

Loading