mbed-SPM updates #9823

orenc17 · 2019-02-24T10:44:55Z

Description

psa_wait_any() & psa_wait_interrupt() replaced with psa_wait()
psa_identity() is replaced with client_id in psa_msg_t
Prepare SPM tests to work with TFM
Fix print warnings
Update secure binaries for FUTURE_SEQUANA_PSA

needs to come in after #9666
This PR is required for #9908 & #9910

Reviewed internally kfnta/mbed-os#91

Pull request type

[ ] Fix
[X] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-psa

Release Notes

ciarmcom · 2019-02-24T12:00:27Z

@orenc17, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

mbed-ci · 2019-02-24T13:41:04Z

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

NirSonnenschein · 2019-02-24T14:28:27Z

CI statred

mikisch81 · 2019-02-25T12:51:19Z

Last 3 commits were to align the PSA SPM tests to TF-M.

Tested on Musca target.

alzix · 2019-02-25T15:41:07Z

Todo list:
[x] psa_get return value must be handled
[ ] PSA header files - single version only. Use TF-M headers.
[x] Generated headers - verify file names and all the macros are actually "standard"
[ ] Error handling. SPM_PANIC macro must not be used from services and replaced by calls to abort()
[ ] Handle abort() calls - make sure to consult with core team

0xc0170 · 2019-02-25T16:22:35Z

@alzix Just to make sure, this todo list completion is blocking this PR?

0xc0170 · 2019-02-26T08:37:55Z

TESTS/mbed-crypto/sanity/main.cpp

@@ -438,7 +438,9 @@ utest::v1::status_t case_teardown_handler(const Case *const source, const size_t

 utest::v1::status_t test_setup(const size_t number_of_cases)
 {
+#ifndef NO_GREENTEA


This is dependency, there's another PR adding this to test framework?

Then should we drop this commit?

mikisch81 · 2019-02-27T07:20:55Z

Rebased this PR after all the merge-fest that was done..

alzix · 2019-02-27T12:50:24Z

usb/mbed_lib.json

@@ -0,0 +1,3 @@
+{
+    "name": "usb"


It is from #9874

components/TARGET_PSA/inc/psa/service.h

alzix · 2019-02-27T13:00:31Z

components/TARGET_PSA/inc/psa/service.h

 #include "TARGET_MBED_SPM/psa_defs.h"
 #include "TARGET_MBED_SPM/COMPONENT_SPE/spm_server.h"
 #include "TARGET_MBED_SPM/COMPONENT_SPE/spm_panic.h"
+#else
+#error "Compiling psa service header on non-secure target is not allowed"


note that the error is misleading.
TARGET_MBED_SPM is applied to both secure and nonsecure targets

Maybe #error "Compiling psa service header on a PSA emulated target is not allowed"

i would phrase it as "expected"

mikisch81 · 2019-02-27T14:19:37Z

@alzix @orenc17 Pushed generation of 'psa_manifest/sid.h' from the tfm generate script.
Did not test it yet.

mikisch81 · 2019-02-27T17:57:57Z

@alzix @orenc17 Now the generation of sid.h is in.

0xc0170 · 2019-02-28T11:06:48Z

@orenc17 What is still to do here?

mikisch81 · 2019-02-28T11:13:41Z

@alzix need to review again

alzix

LGTM
we have registered followups tasks in our backlog.
This PR is required for 5.12, all the required changes will be introduced in followup PRs.

0xc0170 · 2019-02-28T12:57:00Z

CI started

* Add #include <stddef.h> to psa/client.h * Add Attestation service to TFM * Update FUTURE_SEQUANA_PSA secure binaries * Remove MBED_SPM from K64F * Refactor psa_manifest/sid.h * Increase stackl size in spm-client tests * Add handling of errors from psa_get in partitions

NirSonnenschein · 2019-03-03T11:37:53Z

started CI

mbed-ci · 2019-03-03T13:07:09Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 3
Build artifacts

NirSonnenschein · 2019-03-03T13:59:01Z

Note: PR doesn't need to come in after #9312 anymore and CI has passed. @0xc0170 @cmonr any objections to bringing this in?

0xc0170

2 notes:

commits are very brief , it would be better to provide more details in some. For big PR's like this (101 files in 24 commits, more description needed. These are not small fixes). For instance "Update psa_wait() and client_id" why are we updating it and how? We need to get much better in describing changes. Please spend few minutes to provide details.
all new files should have SPDX identifier (should be fixed via new PR)

orenc17 · 2019-03-03T19:24:04Z

@0xc0170 all the new files in this PR have SPDX identifier:
tools/psa/tfm/templates/sid.h.tpl
components/TARGET_PSA/inc/psa_manifest/sid.h

ciarmcom requested review from a team February 24, 2019 12:00

ciarmcom added the needs: review label Feb 24, 2019

mikisch81 approved these changes Feb 25, 2019

View reviewed changes

mikisch81 mentioned this pull request Feb 25, 2019

Add ARM_MUSCA_A1 target #9221

Merged

cmonr added release-version: 5.12.0-rc1 risk: A labels Feb 25, 2019

0xc0170 reviewed Feb 26, 2019

View reviewed changes

orenc17 mentioned this pull request Feb 27, 2019

Default psa headers implementation #9661

Closed

alzix reviewed Feb 27, 2019

View reviewed changes

alzix suggested changes Feb 27, 2019

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Feb 27, 2019

0xc0170 added risk: R and removed risk: A labels Feb 28, 2019

alzix approved these changes Feb 28, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Feb 28, 2019

Oren Cohen and others added 15 commits March 3, 2019 10:55

Update psa_get() to return psa_status_t

306a51f

Move SPM_PANIC to psa/service.h

bd9a738

Test partition modification

a1bd657

Advance to PSA-FF 1.0

737a3cc

Set default PSA client header for single v7 targets

0e74e09

Fix typo

faf5fcf

Call tfm_panic for SPM_PANIC

798e3c3

Generate psa_manifest/sid.h

ef76ec8

Remove another psa_identity

98efb44

Fix astyle

20d7f81

Review fixes

b62c489

Update FUTURE_SEQUANA_M0_PSA default binaries

6341d44

TF-M: Remove not-used platform headers

8fefa25

TF-M: Update tfm_importer.json

4eabce8

Fixes

cfb60ec

* Add #include <stddef.h> to psa/client.h * Add Attestation service to TFM * Update FUTURE_SEQUANA_PSA secure binaries * Remove MBED_SPM from K64F * Refactor psa_manifest/sid.h * Increase stackl size in spm-client tests * Add handling of errors from psa_get in partitions

orenc17 mentioned this pull request Mar 3, 2019

Remove #ifndef NO_GREENTEA from tests #9914

Merged

NirSonnenschein added needs: CI ready for merge and removed needs: work needs: CI labels Mar 3, 2019

0xc0170 removed the needs: preceding PR label Mar 3, 2019

0xc0170 approved these changes Mar 3, 2019

View reviewed changes

0xc0170 merged commit b2fb3d7 into ARMmbed:master Mar 3, 2019

0xc0170 removed the ready for merge label Mar 3, 2019

NirSonnenschein mentioned this pull request Mar 3, 2019

PSA compliance tests suite #9312

Merged

mikisch81 mentioned this pull request Mar 3, 2019

Add support for LPC55S59 #9910

Merged

mbed-SPM updates #9823

mbed-SPM updates #9823

Uh oh!

Conversation

orenc17 commented Feb 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Reviewers

Release Notes

Uh oh!

ciarmcom commented Feb 24, 2019

Uh oh!

mbed-ci commented Feb 24, 2019

Uh oh!

NirSonnenschein commented Feb 24, 2019

Uh oh!

mikisch81 commented Feb 25, 2019

Uh oh!

alzix commented Feb 25, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Feb 25, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikisch81 commented Feb 27, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mikisch81 commented Feb 27, 2019

Uh oh!

mikisch81 commented Feb 27, 2019

Uh oh!

0xc0170 commented Feb 28, 2019

Uh oh!

mikisch81 commented Feb 28, 2019

Uh oh!

alzix left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 28, 2019

Uh oh!

NirSonnenschein commented Mar 3, 2019

Uh oh!

mbed-ci commented Mar 3, 2019

Uh oh!

NirSonnenschein commented Mar 3, 2019

Uh oh!

0xc0170 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

orenc17 commented Mar 3, 2019

Uh oh!

Uh oh!

orenc17 commented Feb 24, 2019 •

edited

Loading

alzix commented Feb 25, 2019 •

edited

Loading

0xc0170 left a comment •

edited

Loading