Skip to content

REST API to C-ECHO a DICOM Destination #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 30, 2022
Merged

REST API to C-ECHO a DICOM Destination #185

merged 9 commits into from
Sep 30, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 29, 2022

Description

Fixes #165 .

A new GET /config/destination/cecho/{name} to perform a C-ECHO to the specified DICOM destination.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Sep 29, 2022
@mocsharp mocsharp added this to the 0.3.2 milestone Sep 29, 2022
@mocsharp mocsharp self-assigned this Sep 29, 2022
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #185 (ebfc2bd) into develop (47f4dec) will decrease coverage by 0.00730%.
The diff coverage is 89.67742%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #185         +/-   ##
===================================================
- Coverage   92.88136%   92.87406%   -0.00731%     
===================================================
  Files            263         268          +5     
  Lines          14750       15198        +448     
  Branches         785         807         +22     
===================================================
+ Hits           13700       14115        +415     
- Misses           811         837         +26     
- Partials         239         246          +7     
Flag Coverage Δ
unittests 92.87406% <89.67742%> (-0.00731%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...InformaticsGateway/Services/Scu/ScuWorkResponse.cs 0.00000% <0.00000%> (ø)
...aticsGateway/Services/Storage/ObjectUploadQueue.cs 88.88889% <0.00000%> (-11.11111%) ⬇️
...y/Test/Services/Storage/ObjectUploadServiceTest.cs 100.00000% <ø> (ø)
.../InformaticsGateway/Services/Scu/ScuWorkRequest.cs 55.00000% <55.00000%> (ø)
src/InformaticsGateway/Services/Scu/ScuService.cs 73.94958% <73.94958%> (ø)
src/Client/Services/AeTitle{T}Service.cs 94.87179% <75.00000%> (-5.12821%) ⬇️
src/InformaticsGateway/Services/Scu/ScuQueue.cs 87.50000% <87.50000%> (ø)
...eway/Services/Http/DestinationAeTitleController.cs 92.10526% <93.75000%> (-0.05160%) ⬇️
...rmaticsGateway/Test/Services/Scu/ScuServiceTest.cs 98.55072% <98.55072%> (ø)
src/CLI/Commands/DestinationCommand.cs 98.69281% <100.00000%> (+0.34569%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f4dec...ebfc2bd. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 2a841ac into develop Sep 30, 2022
@mocsharp mocsharp deleted the vchang/gh-165 branch September 30, 2022 19:39
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.2 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ECHO Endpoint
2 participants