When embedded in the web, clarify how export/import names convert to JS strings #569
Labels
Milestone
Comments
|
SGTM, wanna take a stab at updating Web.md? |
|
Do we want simple failure on the web when conversion fails, or do we want to try to "fix" things? Failure is fine IMO. |
|
Yup! -Filip
|
|
I was thinking eager failure at module compile time. -Filip
|
pizlonator
added a commit
that referenced
this issue
Mar 1, 2016
jfbastien
pushed a commit
that referenced
this issue
Apr 15, 2016
* When embedded in the web, clarify how export/import names convert to JS strings (#569) * Fixes suggested by @jf * Address more feedback Added a link to http://monsur.hossa.in/2012/07/20/utf-8-in-javascript.html. Simplified the decoding algorithm thanks to Luke's feedback.
rossberg
added a commit
that referenced
this issue
Apr 19, 2016
* Prettify section names * Restructure encoding of function signatures * Revert "[Binary 11] Update the version number to 0xB." * Leave index space for growing the number of base types * Comments addressed * clarify how export/import names convert to JS strings (#569) (#573) * When embedded in the web, clarify how export/import names convert to JS strings (#569) * Fixes suggested by @jf * Address more feedback Added a link to http://monsur.hossa.in/2012/07/20/utf-8-in-javascript.html. Simplified the decoding algorithm thanks to Luke's feedback. * Access to proprietary APIs apart from HTML5 (#656) * comments
lukewagner
pushed a commit
that referenced
this issue
Apr 28, 2016
* Prettify section names * Restructure encoding of function signatures * Revert "[Binary 11] Update the version number to 0xB." * Leave index space for growing the number of base types * Comments addressed * clarify how export/import names convert to JS strings (#569) (#573) * When embedded in the web, clarify how export/import names convert to JS strings (#569) * Fixes suggested by @jf * Address more feedback Added a link to http://monsur.hossa.in/2012/07/20/utf-8-in-javascript.html. Simplified the decoding algorithm thanks to Luke's feedback. * Access to proprietary APIs apart from HTML5 (#656) * comments
lukewagner
added a commit
that referenced
this issue
Apr 29, 2016
* Merge pull request #648 from WebAssembly/current_memory Add current_memory operator * Reorder section size field (#639) * Prettify section names (#638) * Extensible encoding of function signatures (#640) * Prettify section names * Restructure encoding of function signatures * Revert "[Binary 11] Update the version number to 0xB." * Leave index space for growing the number of base types * Comments addressed * clarify how export/import names convert to JS strings (#569) (#573) * When embedded in the web, clarify how export/import names convert to JS strings (#569) * Fixes suggested by @jf * Address more feedback Added a link to http://monsur.hossa.in/2012/07/20/utf-8-in-javascript.html. Simplified the decoding algorithm thanks to Luke's feedback. * Access to proprietary APIs apart from HTML5 (#656) * comments * Merge pull request #641 from WebAssembly/postorder_opcodes Postorder opcodes * fix some text that seems to be in the wrong order (#670) * Clarify that br_table has a branch argument (#664) * Add explicit argument counts (#672) * Add explicit arities * Rename * Replace uint8 with varint7 in form field (#662) This needs to be variable-length.
|
Fixed in 04c63fb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When embedded in the web, the exports and imports of a module are represented as JS objects. JS objects are keyed by JS strings, which can be any UCS16 (roughly) sequence. WebAssembly uses sequences of bytes. Therefore, we need to specify conversion rules from WebAssembly byte sequence names to JS strings. There will be JS strings that don't convert gracefully to bytes and vice-versa, so we also need something sensible to happen when the conversion fails.
The text was updated successfully, but these errors were encountered: