Reorder section size field #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Each section is optional and may appear at most once. | ||
| Known sections (from this list) may not appear out of order. | ||
| The actual content of each section is encoded in its `payload_str`. |
There was a problem hiding this comment.
Nit: Instead of "actual content", can we just call it payload or "body"?
There was a problem hiding this comment.
Hm, "The payload is in the payload_str" would seem kind of vacuous; "body" would be okay. But what's wrong with (information) "content"?
There was a problem hiding this comment.
The nit is more with "actual" than content.
There was a problem hiding this comment.
Fair enough, removed the "actual".
|
Objections to this? |
|
Do we want to do this change at the same time as postorder? Seems fine. |
|
lgtm. Our assumption was indeed that this change was in 0xb. |
lukewagner
pushed a commit
that referenced
this pull request
Apr 28, 2016
lukewagner
added a commit
that referenced
this pull request
Apr 29, 2016
* Merge pull request #648 from WebAssembly/current_memory Add current_memory operator * Reorder section size field (#639) * Prettify section names (#638) * Extensible encoding of function signatures (#640) * Prettify section names * Restructure encoding of function signatures * Revert "[Binary 11] Update the version number to 0xB." * Leave index space for growing the number of base types * Comments addressed * clarify how export/import names convert to JS strings (#569) (#573) * When embedded in the web, clarify how export/import names convert to JS strings (#569) * Fixes suggested by @jf * Address more feedback Added a link to http://monsur.hossa.in/2012/07/20/utf-8-in-javascript.html. Simplified the decoding algorithm thanks to Luke's feedback. * Access to proprietary APIs apart from HTML5 (#656) * comments * Merge pull request #641 from WebAssembly/postorder_opcodes Postorder opcodes * fix some text that seems to be in the wrong order (#670) * Clarify that br_table has a branch argument (#664) * Add explicit argument counts (#672) * Add explicit arities * Rename * Replace uint8 with varint7 in form field (#662) This needs to be variable-length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Retargeted from #634.]
Put the size of a section after its name, as suggested in #623.