Skip to content

Conversation

duhenglucky
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

ShadowySpirits and others added 30 commits March 11, 2021 18:11
[ISSUE apache#2730]fix Multiple instances in the same application share MQClientInstance
[ISSUE apache#2801]Fix NamesrvAddr connot set in Producer
…tp (apache#2804)

* fix the endpoint cannot get instanceId without http

* fix the endpoint cannot get instanceId without http

* add unit test

* add unit test

* add unit test

Co-authored-by: panzhi33 <[email protected]>
…ener_npe

[ISSUE apache#2816] fix messageArrivingListener NPE
…topic

[ISSUE apache#2811] Fix the wrong topic was consumed in the DefaultMessageStoreTest test program
[ISSUE apache#2538]Optimize log output when message trace saving fails
…PullConsumer (apache#2832)

* [ISSUE apache#2732] Fix message loss problem when rebalance with LitePullConsumer

* Fix message loss problem when rebalance with LitePullConsumer, update 2
[ISSUE apache#2846]fix -E might not port to other systems
fix some nonconformity after checkstyle
[ISSUE apache#2872] remove log files created by integration test when mvn clean
[ISSUE apache#2872] move log files created by integration test to target dir
francis lee and others added 5 commits May 14, 2021 10:04
[ISSUE apache#2883] [Part A] Improve produce performance in M/S mode.
Bump mockito-core to 3.10.0, remove powermock dependency, suppress useless logging
# Conflicts:
#	client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
#	client/src/test/java/org/apache/rocketmq/client/consumer/DefaultMQPushConsumerTest.java
#	client/src/test/java/org/apache/rocketmq/client/trace/DefaultMQConsumerWithTraceTest.java
#	pom.xml
@vongosling vongosling merged commit ac9aaa4 into apache:pop_consumer May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.