[Default Configuration Part1]: Add defaults mode configuration #2781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoewangg
commented
Oct 20, 2021
| @@ -0,0 +1,53 @@ | |||
| { | |||
| "version": 1, | |||
There was a problem hiding this comment.
This is just a temporary file for development. It will get replaced with the actual file before we release the feature.
zoewangg
force-pushed
the
zoewang/defaults-mode-1
branch
2 times, most recently
from
6790bcf to
23e33a3
Compare
dagnir
approved these changes
Oct 21, 2021
Just a minor comment
core/profiles/src/main/java/software/amazon/awssdk/profiles/ProfileProperty.java
Show resolved
Hide resolved
zoewangg
force-pushed
the
zoewang/defaults-mode-1
branch
from
23e33a3 to
861e4d2
Compare
|
Kudos, SonarCloud Quality Gate passed! |
zoewangg
added a commit
that referenced
this pull request
Dec 17, 2021
* Add support to generate DefaultsMode and implement configuration resolution (#2781) * [Default Configuration Part 2]:Implement auto mode discovery (#2786) * Implement auto mode discovery * Fix tests on CodeBuild * Address feedback * Add comment and rename misnamed constant * [Default Configuration Part 3]: add defaults from defaults mode to the configuration resolution chain (#2803) * Wiring up configuration * Address comments * Add test * Update debug statement and add singleton for AttributeMap * Add tlsNegotiationTimeout (#2814) * [Default Configuration Part 5]: Move default configuration related classes to aws-core (#2816) * Move default configuration related classes to aws-core * Remove extra space and fix build * [Default Configuration Part 6]: apply default s3 us-east-1 regional setting (#2825) * Add s3 regional setting * Rename option name * Fix checkstyle * Update sdk-default-configuraiton.json * Add changelog entry
aws-sdk-java-automation
added a commit
that referenced
this pull request
Nov 14, 2023
…f1ed8b869 Pull request: release <- staging/28d4199e-6322-4b24-a264-2c9f1ed8b869
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note that this will be merged to
feature/master/defaults-modebranch instead of master once approved.DefaultsMode. The generation logic is incodegen-liteand it will get generated when buildingsdk-coreTesting
Added tests
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsLicense