Skip to content

[Default Configuration Part 2]:Implement auto mode discovery #2786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2021
Merged

[Default Configuration Part 2]:Implement auto mode discovery #2786

merged 4 commits into from
Oct 26, 2021

Conversation

zoewangg
Copy link
Contributor

@zoewangg zoewangg commented Oct 22, 2021 •
edited
Loading

Description

Note that this will be merged to feature/master/defaults-mode branch instead of master once approved.

Implement auto mode discovery

Testing

Added tests

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg changed the title Implement auto mode discovery [Default Configuration Part 2]:Implement auto mode discovery Oct 22, 2021
@zoewangg zoewangg force-pushed the zoewang/defaults-mode-2 branch from a23c9ff to 00e4962 Compare October 22, 2021 02:10
@zoewangg zoewangg force-pushed the zoewang/defaults-mode-2 branch from 131f95f to 37fd0db Compare October 22, 2021 18:46
Bennett-Lynch
Bennett-Lynch reviewed Oct 22, 2021
View reviewed changes
Bennett-Lynch
Bennett-Lynch reviewed Oct 25, 2021
View reviewed changes
core/regions/src/main/java/software/amazon/awssdk/regions/internal/util/EC2MetadataUtils.java
if (tries - 1 == 0) {
throw SdkClientException.builder().message("Unable to contact EC2 metadata service.").cause(e).build();
}

// Retry on any other exceptions
Copy link
Contributor

@Bennett-Lynch Bennett-Lynch Oct 25, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment got slightly lost from what it was referencing, on line 401.

Edit: Upon second read, maybe it's fine.

@zoewangg
Copy link
Contributor Author

Not sure why, but the test coverage for the change in this PR got lowered by the change totally unrelated to this PR :(

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2021 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

63.8% 63.8% Coverage
0.0% 0.0% Duplication

@zoewangg zoewangg merged commit 56f5207 into feature/master/defaults-mode Oct 26, 2021
@zoewangg zoewangg deleted the zoewang/defaults-mode-2 branch October 28, 2021 17:47
zoewangg added a commit that referenced this pull request Dec 17, 2021
@zoewangg
Implement defaults mode (#2909)
ee9ea08 
* Add support to generate DefaultsMode and implement configuration resolution (#2781)

* [Default Configuration Part 2]:Implement auto mode discovery (#2786)

* Implement auto mode discovery

* Fix tests on CodeBuild

* Address feedback

* Add comment and rename misnamed constant

* [Default Configuration Part 3]: add defaults from defaults mode to the configuration resolution chain (#2803)

* Wiring up configuration

* Address comments

* Add test

* Update debug statement and add singleton for AttributeMap

* Add tlsNegotiationTimeout (#2814)

* [Default Configuration Part 5]: Move default configuration related classes to aws-core (#2816)

* Move default configuration related classes to aws-core

* Remove extra space and fix build

* [Default Configuration Part 6]: apply default s3 us-east-1 regional setting (#2825)

* Add s3 regional setting

* Rename option name

* Fix checkstyle

* Update sdk-default-configuraiton.json

* Add changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bennett-Lynch Bennett-Lynch Bennett-Lynch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoewangg @Bennett-Lynch