[Default Configuration Part 5]: Move default configuration related classes to aws-core #2816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bennett-Lynch
approved these changes
Nov 4, 2021
core/aws-core/src/main/java/software/amazon/awssdk/awscore/client/builder/AwsClientBuilder.java
Outdated
Show resolved
Hide resolved
...ore/src/main/java/software/amazon/awssdk/awscore/client/builder/AwsDefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
| @@ -170,8 +169,7 @@ | |||
| AWS_MAX_ATTEMPTS("aws.maxAttempts", null), | |||
|
|
|||
| /** | |||
| * Which {@link DefaultsMode} to use, case insensitive | |||
| * @see DefaultsMode | |||
| * Which {@code DefaultsMode} to use, case insensitive | |||
| */ | |||
| AWS_DEFAULTS_MODE("aws.defaultsMode", null), | |||
There was a problem hiding this comment.
Does this still belong in sdk-core?
There was a problem hiding this comment.
We don't actually have an AwsSystemSetting. AWS related system properties such as AWS_ACCESS_KEY_ID are in this class already, so I kept it here to be consistent.
|
Kudos, SonarCloud Quality Gate passed! |
Bennett-Lynch
approved these changes
Nov 4, 2021
zoewangg
added a commit
that referenced
this pull request
Dec 17, 2021
* Add support to generate DefaultsMode and implement configuration resolution (#2781) * [Default Configuration Part 2]:Implement auto mode discovery (#2786) * Implement auto mode discovery * Fix tests on CodeBuild * Address feedback * Add comment and rename misnamed constant * [Default Configuration Part 3]: add defaults from defaults mode to the configuration resolution chain (#2803) * Wiring up configuration * Address comments * Add test * Update debug statement and add singleton for AttributeMap * Add tlsNegotiationTimeout (#2814) * [Default Configuration Part 5]: Move default configuration related classes to aws-core (#2816) * Move default configuration related classes to aws-core * Remove extra space and fix build * [Default Configuration Part 6]: apply default s3 us-east-1 regional setting (#2825) * Add s3 regional setting * Rename option name * Fix checkstyle * Update sdk-default-configuraiton.json * Add changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sdk-coretoaws-coredefaultsModefromClientOverrideConfiguration.defaultsModeto AwsClientBuilderAwsDefaultClientBuilder