Skip to content

updates from testing cpp-linter/cpp-linter-action#81 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 19, 2022

Conversation

2bndy5
Copy link
Collaborator

@2bndy5 2bndy5 commented Aug 12, 2022

This PR is just for testing PR events on the backlogged-updates branch. It is not meant to actually get merged.

It wouldn't hurt to merge this for the submodule and improvements to generating the compilation database on Windows.

I had to disable the database option for the workflow that runs the action with a docker env because it prevents the file annotations from being created.

@2bndy5 2bndy5 force-pushed the test-backlogged-updates branch from 46093a4 to e1371d0 Compare August 12, 2022 06:56
@2bndy5

This comment was marked as outdated.

@2bndy5 2bndy5 force-pushed the test-backlogged-updates branch from e1371d0 to 06184b8 Compare August 19, 2022 06:43
@github-actions
Copy link

📜 Run clang-format on the following files

  • src/demo.cpp
  • src/demo.hpp

💬 Output from clang-tidy

src/demo.cpp
src/demo.cpp:7:8: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

size_t dummyFunc(size_t i) { return i; }
       ^

src/demo.cpp:9:5: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

int main()
~~~ ^
auto       -> int

src/demo.cpp:11:13: warning: [readability-braces-around-statements]

statement should be inside braces

    for (;;) break;
            ^
             {

src/demo.cpp:13:5: warning: [cppcoreguidelines-pro-type-vararg]

do not call c-style vararg functions

    printf("Hello world!\n");
    ^

/usr/include/stdio.h:33:10: error: [clang-diagnostic-error]

'stddef.h' file not found

#include <stddef.h>
         ^


src/demo.hpp
src/demo.hpp:10:11: warning: [modernize-use-trailing-return-type]

use a trailing return type for this function

    void *not_usefull(char *str){
    ~~~~~~^
    auto                         -> void *

src/demo.hpp:12:16: warning: [modernize-use-nullptr]

use nullptr

        return 0;
               ^
               nullptr

@2bndy5 2bndy5 force-pushed the test-backlogged-updates branch from 06184b8 to a32a840 Compare August 19, 2022 06:45
do thread comments when run as action

revert some changes to the demo srcs
@2bndy5 2bndy5 force-pushed the test-backlogged-updates branch from a32a840 to f451ade Compare August 19, 2022 06:50
@2bndy5 2bndy5 changed the title Test backlogged updates updates from testing cpp-linter/cpp-linter-action#81 Aug 19, 2022
@2bndy5 2bndy5 marked this pull request as ready for review August 19, 2022 06:55
@2bndy5 2bndy5 requested a review from shenxianpeng August 19, 2022 06:55
@2bndy5 2bndy5 merged commit 2cf00dc into master Aug 19, 2022
@2bndy5 2bndy5 deleted the test-backlogged-updates branch August 19, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants