Skip to content

rm protoc cmd from pom.xml #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 22, 2025
Merged

rm protoc cmd from pom.xml #1498

merged 8 commits into from
Aug 22, 2025

Conversation

cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Aug 13, 2025

Locally I have a diff protoc version. That results in a crazy bad error. To not use a developers local protoc Im removing it so cmds like mvn clean install will run without error.

I believe it fixes this issue or is at least a very similar err. See the err in the attached file.
protoc-issue.txt

Also noticed CI throwing:

Run ./mvnw compile -B -q
protoc-jar: executing: [protoc, --version]
protoc-jar: caught exception, retrying: java.io.IOException: Cannot run program "protoc": error=2, No such file or directory
protoc-jar: executing: [protoc, --version]
protoc-jar: caught exception, retrying: java.io.IOException: Cannot run program "protoc": error=2, No such file or directory
protoc-jar: executing: [protoc, --version]
protoc-jar: executing: [/tmp/protoc18031117828517050527.exe, --version]
libprotoc 25.5

…ion and results in a bad error

Signed-off-by: Cassandra Coyle <[email protected]>
@cicoyle cicoyle requested review from a team as code owners August 13, 2025 21:40
artur-ciocanu
artur-ciocanu previously approved these changes Aug 14, 2025
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this mean that the Maven plugin will use its internal protoc version?

@dapr-bot dapr-bot merged commit 62b01c6 into dapr:master Aug 22, 2025
9 of 10 checks passed
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.70%. Comparing base (d759c53) to head (76a6d0d).
⚠️ Report is 200 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1498      +/-   ##
============================================
+ Coverage     76.91%   78.70%   +1.78%     
- Complexity     1592     1918     +326     
============================================
  Files           145      237      +92     
  Lines          4843     5926    +1083     
  Branches        562      610      +48     
============================================
+ Hits           3725     4664     +939     
- Misses          821      939     +118     
- Partials        297      323      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants