Skip to content

Conversation

javier-aliaga
Copy link
Contributor

@javier-aliaga javier-aliaga commented Sep 2, 2025

Description

Copy changes from master to release-1.16

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@javier-aliaga javier-aliaga force-pushed the master-to-1.16 branch 2 times, most recently from 8089a80 to ce44351 Compare September 2, 2025 15:34
cicoyle and others added 6 commits September 2, 2025 17:34
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
* Use camelCase on properties

Signed-off-by: Matheus Cruz <[email protected]>

* Add test for cameCalse properties

Signed-off-by: Matheus Cruz <[email protected]>

* Update daprdocs/content/en/java-sdk-docs/spring-boot/_index.md

Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Matheus Cruz <[email protected]>

---------

Signed-off-by: Matheus Cruz <[email protected]>
Signed-off-by: Matheus Cruz <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: salaboy <[email protected]>
Co-authored-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Co-authored-by: Siri Varma Vegiraju <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
* rm protoc cmd bc it uses a local protoc which might be the wrong version and results in a bad error

Signed-off-by: Cassandra Coyle <[email protected]>

* update protoc

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Co-authored-by: salaboy <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
javier-aliaga and others added 15 commits September 2, 2025 17:49
* feat: Support register of activities with custom name

Signed-off-by: Javier Aliaga <[email protected]>

* chore: Apply suggestions

Signed-off-by: Javier Aliaga <[email protected]>

---------

Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.4.3 to 5.5.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v5.4.3...v5.5.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 5.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
* chore: New task execution task id test

test how taskExecutionTaskId can be used for idempotency

* chore: Clean up not used files

* docs: Task execution keys

* test: Modify unit tests

* Remove new lines

---------

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: artur-ciocanu <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Siri Varma Vegiraju <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
* chore: Wait for dapr script

When running mechanical markdown examples wait for dapr to be running

Signed-off-by: Javier Aliaga <[email protected]>

* chore: Fix build ci

Signed-off-by: Javier Aliaga <[email protected]>

* chore: Fix build ci

Signed-off-by: Javier Aliaga <[email protected]>

---------

Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: salaboy <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
* chore: Read test certs from resources folder

This will avoid importing bouncy castle library just for tests

Signed-off-by: Javier Aliaga <[email protected]>

* ci: Split unit test and integration tests

Signed-off-by: Javier Aliaga <[email protected]>

---------

Signed-off-by: Javier Aliaga <[email protected]>
* chore: Bump dapr version

Signed-off-by: Javier Aliaga <[email protected]>

* chore: Fix conversation tests

Only one response expected

Signed-off-by: Javier Aliaga <[email protected]>

---------

Signed-off-by: Javier Aliaga <[email protected]>
* Adding logger to WorkflowActivityContext

Signed-off-by: Artur Ciocanu <[email protected]>

* Fixing a styling issue

Signed-off-by: Artur Ciocanu <[email protected]>

* Add unit tests for workflow activity context

Signed-off-by: Artur Ciocanu <[email protected]>

* Add more unit tests to make Codecov happy

Signed-off-by: Artur Ciocanu <[email protected]>

* Add more unit tests

Signed-off-by: Artur Ciocanu <[email protected]>

* Improve code coverage

Signed-off-by: Artur Ciocanu <[email protected]>

* Improve test names

Signed-off-by: Artur Ciocanu <[email protected]>

---------

Signed-off-by: Artur Ciocanu <[email protected]>
Co-authored-by: Artur Ciocanu <[email protected]>
Co-authored-by: salaboy <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
* cross app ex

Signed-off-by: Cassandra Coyle <[email protected]>

* update protoc cmd

Signed-off-by: Cassandra Coyle <[email protected]>

* feedback

Signed-off-by: Cassandra Coyle <[email protected]>

* builder pattern

Signed-off-by: Cassandra Coyle <[email protected]>

* fix protoc

Signed-off-by: Cassandra Coyle <[email protected]>

* debug log levels for test containers

Signed-off-by: Cassandra Coyle <[email protected]>

* update readme and add debugging info

Signed-off-by: Cassandra Coyle <[email protected]>

* add IT test for cross app call activity

Signed-off-by: Cassandra Coyle <[email protected]>

* cleanup test

Signed-off-by: Cassandra Coyle <[email protected]>

* sysout -> ctx.logger

Signed-off-by: Cassandra Coyle <[email protected]>

* reset pom

Signed-off-by: Cassandra Coyle <[email protected]>

* rm debug lines from readme

Signed-off-by: Cassandra Coyle <[email protected]>

* fix header + rm customports

Signed-off-by: Cassandra Coyle <[email protected]>

* use consts

Signed-off-by: Cassandra Coyle <[email protected]>

* rm waitfor call

Signed-off-by: Cassandra Coyle <[email protected]>

* rm pubsub

Signed-off-by: Cassandra Coyle <[email protected]>

* rm timeout

Signed-off-by: Cassandra Coyle <[email protected]>

* reset empty lines added

Signed-off-by: Cassandra Coyle <[email protected]>

* reset appname for daprcontainer

Signed-off-by: Cassandra Coyle <[email protected]>

* reset empty line diff

Signed-off-by: Cassandra Coyle <[email protected]>

* rm constructor info from readme

Signed-off-by: Cassandra Coyle <[email protected]>

* debug -> info

Signed-off-by: Cassandra Coyle <[email protected]>

* rm super.start

Signed-off-by: Cassandra Coyle <[email protected]>

* reset dapr container diff

Signed-off-by: Cassandra Coyle <[email protected]>

* add test for codecov

Signed-off-by: Cassandra Coyle <[email protected]>

* up timeout time to unblock PR

Signed-off-by: Cassandra Coyle <[email protected]>

* deps: Update durabletask-client to 1.5.10

Signed-off-by: Javier Aliaga <[email protected]>

* ci: Revert build timeout

Signed-off-by: Javier Aliaga <[email protected]>

* review: Use ctx.getLogger

Signed-off-by: Javier Aliaga <[email protected]>

* chore: Fix review comments

Signed-off-by: Javier Aliaga <[email protected]>

* chore: more review comments fixes

Signed-off-by: Javier Aliaga <[email protected]>

* test: Use testcontainers in CrossApp IT test

Signed-off-by: Javier Aliaga <[email protected]>

* chore: Load classpath for IT with all dependencies

Signed-off-by: Javier Aliaga <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Javier Aliaga <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Dapr Bot <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
@javier-aliaga javier-aliaga marked this pull request as ready for review September 3, 2025 07:19
@javier-aliaga javier-aliaga requested review from a team as code owners September 3, 2025 07:19
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salaboy salaboy merged commit 726c1b0 into dapr:release-1.16 Sep 3, 2025
10 of 11 checks passed
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.16@6e8e37d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...orkflows/runtime/WorkflowActivityClassWrapper.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.16    #1541   +/-   ##
===============================================
  Coverage                ?   78.89%           
  Complexity              ?     1934           
===============================================
  Files                   ?      237           
  Lines                   ?     5952           
  Branches                ?      611           
===============================================
  Hits                    ?     4696           
  Misses                  ?      936           
  Partials                ?      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants