chore: New task execution task id test #1352

javier-aliaga · 2025-05-13T15:55:12Z

Description

test how taskExecutionTaskId can be used for idempotency

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

Code compiles correctly
Created/updated tests
Extended the documentation

cicoyle

Thanks for adding this feature! Mostly lgtm - mind adding a section or note about this somewhere in the daprdocs/?

Something as simple as saying use the ctx.getTaskExecutionKey() for xyz reasons will suffice.

Also, please ensure the header is added to every file

test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]>

Signed-off-by: Javier Aliaga <[email protected]>

javier-aliaga · 2025-05-20T11:24:44Z

Thanks for adding this feature! Mostly lgtm - mind adding a section or note about this somewhere in the daprdocs/?

Something as simple as saying use the ctx.getTaskExecutionKey() for xyz reasons will suffice.

Also, please ensure the header is added to every file

Done!

https://github.com/dapr/java-sdk/blob/ec48fe46bbadf1b44759c2a6167d8d5fb2afab88/daprdocs/content/en/java-sdk-docs/java-workflow/java-workflow-howto.md#advanced-features

Signed-off-by: Javier Aliaga <[email protected]>

daprdocs/content/en/java-sdk-docs/java-workflow/java-workflow-howto.md

artur-ciocanu · 2025-05-22T15:45:03Z

@javier-aliaga would you have sometime to address the review comments so we could merge this one. Thank you!

Signed-off-by: artur-ciocanu <[email protected]>

artur-ciocanu

@javier-aliaga this looks great! 🙇

artur-ciocanu · 2025-05-23T02:47:05Z

@cicoyle if this looks good, could please re-approve. Thank you.

siri-varma

LGTM

codecov · 2025-05-28T14:44:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (d759c53) to head (34715a9).
Report is 155 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1352      +/-   ##
============================================
+ Coverage     76.91%   78.17%   +1.26%     
- Complexity     1592     1832     +240     
============================================
  Files           145      223      +78     
  Lines          4843     5664     +821     
  Branches        562      601      +39     
============================================
+ Hits           3725     4428     +703     
- Misses          821      916      +95     
- Partials        297      320      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This reverts commit 949584f.

This reverts commit 949584f. Signed-off-by: Javier Aliaga <[email protected]>

* adding remote endpoint request from inside activity with retry Signed-off-by: salaboy <[email protected]> * adding retry with Microcks payloads Signed-off-by: salaboy <[email protected]> * fixing review comments Signed-off-by: salaboy <[email protected]> * chore: New task execution task id test (#1352) * chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]> * chore: Clean up not used files Signed-off-by: Javier Aliaga <[email protected]> * docs: Task execution keys Signed-off-by: Javier Aliaga <[email protected]> * test: Modify unit tests Signed-off-by: Javier Aliaga <[email protected]> * Remove new lines Signed-off-by: artur-ciocanu <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> * Revert "chore: New task execution task id test (#1352)" (#1389) This reverts commit 949584f. Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * 1.5.5 (#1390) Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Add Documentation for Conversation AI SDK (#1387) Signed-off-by: salaboy <[email protected]> * Cleanup Spring Dependencies (#1334) * Update CONTRIBUTING.md Signed-off-by: Siri Varma Vegiraju <[email protected]> * Fix spring Signed-off-by: siri-varma <[email protected]> * Add context Signed-off-by: siri-varma <[email protected]> * Phase 1 Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * Fix spring Signed-off-by: siri-varma <[email protected]> * Add context Signed-off-by: siri-varma <[email protected]> * Phase 1 Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * move version Signed-off-by: sirivarma <[email protected]> * Fix pom Signed-off-by: sirivarma <[email protected]> * change version Signed-off-by: sirivarma <[email protected]> * remove unused Signed-off-by: siri-varma <[email protected]> * Address comments Signed-off-by: siri-varma <[email protected]> * Fix test Signed-off-by: siri-varma <[email protected]> * Fix test Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: sirivarma <[email protected]> --------- Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: siri-varma <[email protected]> Signed-off-by: sirivarma <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> * network is needed Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: siri-varma <[email protected]> Signed-off-by: sirivarma <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]>

* chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]> * chore: Clean up not used files Signed-off-by: Javier Aliaga <[email protected]> * docs: Task execution keys Signed-off-by: Javier Aliaga <[email protected]> * test: Modify unit tests Signed-off-by: Javier Aliaga <[email protected]> * Remove new lines Signed-off-by: artur-ciocanu <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>

* chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]> * chore: Clean up not used files Signed-off-by: Javier Aliaga <[email protected]> * docs: Task execution keys Signed-off-by: Javier Aliaga <[email protected]> * test: Modify unit tests Signed-off-by: Javier Aliaga <[email protected]> * Remove new lines Signed-off-by: artur-ciocanu <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: sirivarma <[email protected]>

This reverts commit 949584f. Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: sirivarma <[email protected]>

…1388) * adding remote endpoint request from inside activity with retry Signed-off-by: salaboy <[email protected]> * adding retry with Microcks payloads Signed-off-by: salaboy <[email protected]> * fixing review comments Signed-off-by: salaboy <[email protected]> * chore: New task execution task id test (dapr#1352) * chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]> * chore: Clean up not used files Signed-off-by: Javier Aliaga <[email protected]> * docs: Task execution keys Signed-off-by: Javier Aliaga <[email protected]> * test: Modify unit tests Signed-off-by: Javier Aliaga <[email protected]> * Remove new lines Signed-off-by: artur-ciocanu <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> * Revert "chore: New task execution task id test (dapr#1352)" (dapr#1389) This reverts commit 949584f. Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: salaboy <[email protected]> * 1.5.5 (dapr#1390) Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: salaboy <[email protected]> * Add Documentation for Conversation AI SDK (dapr#1387) Signed-off-by: salaboy <[email protected]> * Cleanup Spring Dependencies (dapr#1334) * Update CONTRIBUTING.md Signed-off-by: Siri Varma Vegiraju <[email protected]> * Fix spring Signed-off-by: siri-varma <[email protected]> * Add context Signed-off-by: siri-varma <[email protected]> * Phase 1 Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * Fix spring Signed-off-by: siri-varma <[email protected]> * Add context Signed-off-by: siri-varma <[email protected]> * Phase 1 Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: siri-varma <[email protected]> * move version Signed-off-by: sirivarma <[email protected]> * Fix pom Signed-off-by: sirivarma <[email protected]> * change version Signed-off-by: sirivarma <[email protected]> * remove unused Signed-off-by: siri-varma <[email protected]> * Address comments Signed-off-by: siri-varma <[email protected]> * Fix test Signed-off-by: siri-varma <[email protected]> * Fix test Signed-off-by: siri-varma <[email protected]> * Fix things Signed-off-by: sirivarma <[email protected]> --------- Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: siri-varma <[email protected]> Signed-off-by: sirivarma <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: salaboy <[email protected]> * network is needed Signed-off-by: salaboy <[email protected]> --------- Signed-off-by: salaboy <[email protected]> Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Signed-off-by: Cassandra Coyle <[email protected]> Signed-off-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: siri-varma <[email protected]> Signed-off-by: sirivarma <[email protected]> Co-authored-by: Javier Aliaga <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Co-authored-by: Siri Varma Vegiraju <[email protected]> Signed-off-by: sirivarma <[email protected]>

* chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]> * chore: Clean up not used files Signed-off-by: Javier Aliaga <[email protected]> * docs: Task execution keys Signed-off-by: Javier Aliaga <[email protected]> * test: Modify unit tests Signed-off-by: Javier Aliaga <[email protected]> * Remove new lines Signed-off-by: artur-ciocanu <[email protected]> --------- Signed-off-by: Javier Aliaga <[email protected]> Signed-off-by: artur-ciocanu <[email protected]> Co-authored-by: Cassie Coyle <[email protected]> Co-authored-by: artur-ciocanu <[email protected]> Signed-off-by: Javier Aliaga <[email protected]>

javier-aliaga changed the title ~~[WIP] chore: New task execution task id test~~ chore: New task execution task id test May 13, 2025

javier-aliaga marked this pull request as ready for review May 13, 2025 16:06

javier-aliaga requested review from a team as code owners May 13, 2025 16:06

javier-aliaga force-pushed the ja-task-idempotency-keys branch 2 times, most recently from ae29385 to 45872ef Compare May 15, 2025 16:14

cicoyle requested changes May 16, 2025

View reviewed changes

javier-aliaga closed this May 20, 2025

javier-aliaga reopened this May 20, 2025

javier-aliaga force-pushed the ja-task-idempotency-keys branch from 9de2450 to 97f8e2f Compare May 20, 2025 10:50

javier-aliaga added 2 commits May 20, 2025 13:00

chore: New task execution task id test

3c7e413

test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <[email protected]>

chore: Clean up not used files

3434802

Signed-off-by: Javier Aliaga <[email protected]>

javier-aliaga force-pushed the ja-task-idempotency-keys branch from 97f8e2f to 3434802 Compare May 20, 2025 11:00

docs: Task execution keys

90b11d6

Signed-off-by: Javier Aliaga <[email protected]>

javier-aliaga force-pushed the ja-task-idempotency-keys branch from ec48fe4 to 90b11d6 Compare May 20, 2025 11:23

test: Modify unit tests

5557439

Signed-off-by: Javier Aliaga <[email protected]>

javier-aliaga requested a review from cicoyle May 20, 2025 13:26

Merge branch 'master' into ja-task-idempotency-keys

da29688

cicoyle reviewed May 21, 2025

View reviewed changes

daprdocs/content/en/java-sdk-docs/java-workflow/java-workflow-howto.md Outdated Show resolved Hide resolved

cicoyle and others added 2 commits May 22, 2025 16:56

Merge branch 'master' into ja-task-idempotency-keys

8869369

Remove new lines

2eb20e6

Signed-off-by: artur-ciocanu <[email protected]>

artur-ciocanu approved these changes May 23, 2025

View reviewed changes

Merge branch 'master' into ja-task-idempotency-keys

34715a9

siri-varma approved these changes May 27, 2025

View reviewed changes

cicoyle approved these changes May 28, 2025

View reviewed changes

cicoyle merged commit 949584f into dapr:master May 28, 2025
9 checks passed

javier-aliaga added a commit to javier-aliaga/java-sdk that referenced this pull request May 28, 2025

Revert "chore: New task execution task id test (dapr#1352)"

8b880bc

This reverts commit 949584f.

javier-aliaga added a commit to javier-aliaga/java-sdk that referenced this pull request May 28, 2025

Revert "chore: New task execution task id test (dapr#1352)"

371fb44

This reverts commit 949584f. Signed-off-by: Javier Aliaga <[email protected]>

cicoyle pushed a commit that referenced this pull request May 28, 2025

Revert "chore: New task execution task id test (#1352)" (#1389)

ba3b529

This reverts commit 949584f. Signed-off-by: Javier Aliaga <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: New task execution task id test #1352

chore: New task execution task id test #1352

Uh oh!

javier-aliaga commented May 13, 2025 •

edited

Loading

Uh oh!

cicoyle left a comment

Uh oh!

javier-aliaga commented May 20, 2025

Uh oh!

Uh oh!

artur-ciocanu commented May 22, 2025

Uh oh!

artur-ciocanu left a comment •

edited

Loading

Uh oh!

artur-ciocanu commented May 23, 2025

Uh oh!

siri-varma left a comment

Uh oh!

Uh oh!

codecov bot commented May 28, 2025

Uh oh!

Uh oh!

chore: New task execution task id test #1352

chore: New task execution task id test #1352

Uh oh!

Conversation

javier-aliaga commented May 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue reference

Checklist

Uh oh!

cicoyle left a comment

Choose a reason for hiding this comment

Uh oh!

javier-aliaga commented May 20, 2025

Uh oh!

Uh oh!

artur-ciocanu commented May 22, 2025

Uh oh!

artur-ciocanu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

artur-ciocanu commented May 23, 2025

Uh oh!

siri-varma left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented May 28, 2025

Codecov Report

Uh oh!

Uh oh!

javier-aliaga commented May 13, 2025 •

edited

Loading

artur-ciocanu left a comment •

edited

Loading