Skip to content

Close related editors when "Remove from editor" is selected on folder in Files view #2703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danrubel opened this issue Apr 23, 2012 · 1 comment
Assignees
Labels
closed-obsolete Closed as the reported issue is no longer relevant

Comments

@danrubel
Copy link

Defect from Luke

Open a bunch of projects and their files in multiple different projects.

Select all the projects and hit 'remove from editor' - it doesn't remove the windows from the RHS and shows a big scarey red ! instead with 'Could not open the editor: The file does not exist'.
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 5762
////////////////////////////////////////////////////////////////////////////////////
OS: Mac OS X - x86_64 (10.7.3)
SDK installed = true
Dartium installed = true
////////////////////////////////////////////////////////////////////////////////////

!SESSION 2012-04-20 03:18:20.971 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.6.0_31
java.vendor=Apple Inc.
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=en_US
Framework arguments: -keyring ${user.home}/.eclipse_keyring -showlocation
Command-line arguments: -os macosx -ws cocoa -arch x86_64 -consoleLog -data ../../../workspace -keyring ${user.home}/.eclipse_keyring -showlocation

!ENTRY org.eclipse.ui 4 0 2012-04-20 03:18:42.074
!MESSAGE Unable to create editor ID com.google.dart.tools.ui.text.editor.CompilationUnitEditor: The file does not exist.
!STACK 1
org.eclipse.core.runtime.CoreException: The file does not exist.
       at org.eclipse.core.internal.filebuffers.ResourceFileBuffer.create(ResourceFileBuffer.java:237)
       at org.eclipse.core.internal.filebuffers.TextFileBufferManager.connect(TextFileBufferManager.java:112)
       at org.eclipse.ui.editors.text.TextFileDocumentProvider.createFileInfo(TextFileDocumentProvider.java:559)
       at org.eclipse.ui.editors.text.TextFileDocumentProvider.connect(TextFileDocumentProvider.java:478)
       at org.eclipse.ui.editors.text.ForwardingDocumentProvider.connect(ForwardingDocumentProvider.java:114)
       at org.eclipse.ui.editors.text.TextFileDocumentProvider.connect(TextFileDocumentProvider.java:480)
       at com.google.dart.tools.ui.internal.text.editor.CompilationUnitDocumentProvider.connect(CompilationUnitDocumentProvider.java:892)
       at org.eclipse.ui.texteditor.AbstractTextEditor.doSetInput(AbstractTextEditor.java:4213)
       at org.eclipse.ui.texteditor.StatusTextEditor.doSetInput(StatusTextEditor.java:237)
       at org.eclipse.ui.texteditor.AbstractDecoratedTextEditor.doSetInput(AbstractDecoratedTextEditor.java:1451)
       at com.google.dart.tools.ui.internal.text.editor.DartEditor.internalDoSetInput(DartEditor.java:3927)
       at com.google.dart.tools.ui.internal.text.editor.DartEditor.doSetInput(DartEditor.java:2748)
       at com.google.dart.tools.ui.internal.text.editor.CompilationUnitEditor.doSetInput(CompilationUnitEditor.java:1566)
       at org.eclipse.ui.texteditor.AbstractTextEditor$19.run(AbstractTextEditor.java:3200)
       at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
       at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
       at org.eclipse.jface.window.ApplicationWindow$1.run(ApplicationWindow.java:759)
       at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
       at org.eclipse.jface.window.ApplicationWindow.run(ApplicationWindow.java:756)
       at org.eclipse.ui.internal.WorkbenchWindow.run(WorkbenchWindow.java:2642)
       at org.eclipse.ui.texteditor.AbstractTextEditor.internalInit(AbstractTextEditor.java:3218)
       at org.eclipse.ui.texteditor.AbstractTextEditor.init(AbstractTextEditor.java:3245)
       at org.eclipse.ui.internal.EditorManager.createSite(EditorManager.java:828)
       at org.eclipse.ui.internal.EditorReference.createPartHelper(EditorReference.java:647)
       at org.eclipse.ui.internal.EditorReference.createPart(EditorReference.java:465)
       at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:595)
       at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:313)
       at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180)
       at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270)
       at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
       at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473)
       at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1245)
       at org.eclipse.ui.internal.PartStack.handleDeferredEvents(PartStack.java:1213)
       at org.eclipse.ui.internal.LayoutPart.deferUpdates(LayoutPart.java:400)
       at org.eclipse.ui.internal.PartSashContainer.handleDeferredEvents(PartSashContainer.java:1409)
       at org.eclipse.ui.internal.LayoutPart.deferUpdates(LayoutPart.java:400)
       at org.eclipse.ui.internal.WorkbenchPage.handleDeferredEvents(WorkbenchPage.java:1495)
       at org.eclipse.ui.internal.WorkbenchPage.deferUpdates(WorkbenchPage.java:1485)
       at org.eclipse.ui.internal.WorkbenchPage.closeEditors(WorkbenchPage.java:1459)
       at org.eclipse.ui.internal.WorkbenchPage.closeEditor(WorkbenchPage.java:1523)
       at org.eclipse.ui.texteditor.AbstractTextEditor$23.run(AbstractTextEditor.java:4313)
       at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
       at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
       at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3935)
       at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3612)
       at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
       at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
       at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
       at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
       at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
       at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
       at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
       at com.google.dart.tools.deploy.DartIDEApplication.start(DartIDEApplication.java:44)
       at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
       at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
       at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
       at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
       at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:597)
       at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
       at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
       at org.eclipse.equinox.launcher.Main.run(Main.java:1410)
!SUBENTRY 1 org.eclipse.core.filebuffers 4 0 2012-04-20 03:18:42.081
!MESSAGE The file does not exist.

!ENTRY org.eclipse.ui 2 2 2012-04-20 03:18:42.096
!MESSAGE Ignored attempt to add saveable that was already registered
!STACK 0
org.eclipse.core.runtime.AssertionFailedException: unknown saveable: org.eclipse.ui.internal.DefaultSaveable@10181f5b from part: org.eclipse.ui.internal.ErrorEditorPart@10181f5b
       at org.eclipse.ui.internal.SaveablesList.logWarning(SaveablesList.java:187)
       at org.eclipse.ui.internal.SaveablesList.addModel(SaveablesList.java:117)
       at org.eclipse.ui.internal.SaveablesList.addModels(SaveablesList.java:289)
       at org.eclipse.ui.internal.SaveablesList.postOpen(SaveablesList.java:695)
       at org.eclipse.ui.internal.PartList.partOpened(PartList.java:234)
       at org.eclipse.ui.internal.PartList.access$0(PartList.java:210)
       at org.eclipse.ui.internal.PartList$1.propertyChanged(PartList.java:40)
       at org.eclipse.ui.internal.WorkbenchPartReference.fireInternalPropertyChange(WorkbenchPartReference.java:375)
       at org.eclipse.ui.internal.WorkbenchPartReference.getPart(WorkbenchPartReference.java:610)
       at org.eclipse.ui.internal.PartPane.setVisible(PartPane.java:313)
       at org.eclipse.ui.internal.presentations.PresentablePart.setVisible(PresentablePart.java:180)
       at org.eclipse.ui.internal.presentations.util.PresentablePartFolder.select(PresentablePartFolder.java:270)
       at org.eclipse.ui.internal.presentations.util.LeftToRightTabOrder.select(LeftToRightTabOrder.java:65)
       at org.eclipse.ui.internal.presentations.util.TabbedStackPresentation.selectPart(TabbedStackPresentation.java:473)
       at org.eclipse.ui.internal.PartStack.refreshPresentationSelection(PartStack.java:1245)
       at org.eclipse.ui.internal.PartStack.handleDeferredEvents(PartStack.java:1213)
       at org.eclipse.ui.internal.LayoutPart.deferUpdates(LayoutPart.java:400)
       at org.eclipse.ui.internal.PartSashContainer.handleDeferredEvents(PartSashContainer.java:1409)
       at org.eclipse.ui.internal.LayoutPart.deferUpdates(LayoutPart.java:400)
       at org.eclipse.ui.internal.WorkbenchPage.handleDeferredEvents(WorkbenchPage.java:1495)
       at org.eclipse.ui.internal.WorkbenchPage.deferUpdates(WorkbenchPage.java:1485)
       at org.eclipse.ui.internal.WorkbenchPage.closeEditors(WorkbenchPage.java:1459)
       at org.eclipse.ui.internal.WorkbenchPage.closeEditor(WorkbenchPage.java:1523)
       at org.eclipse.ui.texteditor.AbstractTextEditor$23.run(AbstractTextEditor.java:4313)
       at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
       at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
       at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3935)
       at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3612)
       at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
       at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
       at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
       at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
       at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
       at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
       at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
       at com.google.dart.tools.deploy.DartIDEApplication.start(DartIDEApplication.java:44)
       at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
       at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
       at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
       at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
       at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
       at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
       at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
       at java.lang.reflect.Method.invoke(Method.java:597)
       at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
       at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
       at org.eclipse.equinox.launcher.Main.run(Main.java:1410)

@pq
Copy link
Member

pq commented May 9, 2012

I've seen this before but no longer able to reproduce... re-open if I've been too hasty!


Added AssumedStale label.

@danrubel danrubel added Type-Defect closed-obsolete Closed as the reported issue is no longer relevant labels May 9, 2012
dart-bot pushed a commit that referenced this issue Nov 6, 2020
New commits:

git log --format="%C(auto) %h %s" 900e796a37fd9f68de9dd183cf4798fe5f055eaa..4ca4767a6c00b2dadecdaee9a4866dae40ef25f2
 4ca4767a Added a dart pub outdated --transitive option (#2731)
 6b145bd6 Deprecate --server argument to `pub publish` and `pub uploader`. (#2697)
 7737023a don't warn if previous prerelease was null safe (#2730)
 62f92838 Improve outdated --mode=null-safety (#2724)
 cc589ec3 Change message for no Latest resolution (#2729)
 656803e9 Require sdk constraint (#2718)
 8309d877 Added test that dev_dependency does not trigger null-safety warnings when publishing (#2727)
 332ea049 Remove warning about mixed mode. (#2723)
 a98a1f23 Simplify null-safety analysis in `pub outdated --mode=null-safety` (#2721)
 5fba2015 Outdated null safety implies prereleases (#2722)
 fb9ec4af Fixed bug in yaml_edit (#2703)

Change-Id: I22a084aee06542e04a272269fb0134f0ac62f779
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170690
Commit-Queue: Sigurd Meldgaard <[email protected]>
Reviewed-by: Michael Thomsen <[email protected]>
Reviewed-by: Jonas Jensen <[email protected]>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-obsolete Closed as the reported issue is no longer relevant
Projects
None yet
Development

No branches or pull requests

2 participants